stmmac patches...

stmmac patches...

[David Miller]

Please do not intermix coding style changes with bug
fixes.

In your second patch you change the indentation of
the arguments to ->init_rx_desc() in stmmac_suspend()

Not only is this inappropriate in a bug fix patch, it
is actually making the indentation incorrect.  The
arguments should line up to the column after the
function argument set openning '(' on the previous
line.

Please fix this up and resubmit both of your patches.

Thank you.

Re: stmmac patches...

[Giuseppe CAVALLARO]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi David,

David Miller wrote:
> Please do not intermix coding style changes with bug
> fixes.
> 
> In your second patch you change the indentation of
> the arguments to ->init_rx_desc() in stmmac_suspend()
> 
> Not only is this inappropriate in a bug fix patch, it
> is actually making the indentation incorrect.  The
> arguments should line up to the column after the
> function argument set openning '(' on the previous
> line.

I agree with you and thanks for your feedback.

> Please fix this up and resubmit both of your patches.

I've just resent the second patch:
 [PATCH (RESENT)] stmmac: do not fail when the timer cannot be used.
Let me know if I have to review something in my first patch as well.

Peppe

> 
> Thank you.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAksGQvIACgkQ2Xo3j31MSSKodQCgopGgPPXTU+K5xESR5WXawTlc
MagAn21fS/y+pCAuiOoJVbOU5Z79yqWt
=58TT
-----END PGP SIGNATURE-----

Re: stmmac patches...

[David Miller]

From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Fri, 20 Nov 2009 08:19:14 +0100

>> Please fix this up and resubmit both of your patches.
> 
> I've just resent the second patch:
>  [PATCH (RESENT)] stmmac: do not fail when the timer cannot be used.
> Let me know if I have to review something in my first patch as well.

I explicitly asked you to resubmit both patches, so that I would have
them in a group together to apply to my tree.

When changes are requested in some patches within a group, I mark
the entire group in patchwork with state 'changed requested' and
that's why I ask for the whole series to be resubmitted.

This means you should have resent the first patch even though I did
not ask you to make any changes to it.

Re: stmmac patches...

[Giuseppe CAVALLARO]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi David,
David Miller wrote:
> From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
> Date: Fri, 20 Nov 2009 08:19:14 +0100
> 
>>> Please fix this up and resubmit both of your patches.
>> I've just resent the second patch:
>>  [PATCH (RESENT)] stmmac: do not fail when the timer cannot be used.
>> Let me know if I have to review something in my first patch as well.
> 
> I explicitly asked you to resubmit both patches, so that I would have
> them in a group together to apply to my tree.

I'm sending them at once.

> When changes are requested in some patches within a group, I mark
> the entire group in patchwork with state 'changed requested' and
> that's why I ask for the whole series to be resubmitted.
> 
> This means you should have resent the first patch even though I did
> not ask you to make any changes to it.

Thanks David for this. I know that it's not easy to manage an huge
amount of patches (especially when these have some defects ;-) ). My
personal goal is to sent patches clean and well done too.

Regards,
Peppe
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAksKTpEACgkQ2Xo3j31MSSI3XACfVFcY9yj2fzFOplC8A1oma9lp
6QYAmgNdMKvJt+MyUAZHsIqjqDpDAwdD
=Z6CD
-----END PGP SIGNATURE-----