From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: therbert@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] net: Xmit Packet Steering (XPS)
Date: Fri, 20 Nov 2009 23:36:22 +0100 [thread overview]
Message-ID: <4B0719E6.4060402@gmail.com> (raw)
In-Reply-To: <20091120.143218.252563862.davem@davemloft.net>
David Miller a écrit :
>
> I like this work. But as you know it still needs a little bit
> more work :-)
>
> Let's also pick a more decent name for the free function since
> tons of drivers are going to call this thing. How about
> dev_kfree_tx_skb()? :-)
>
> I see Jarek and you have come to a mutual understanding about the
> locking. Since you need to change it anyways to fix the deadlock,
> what using a netchannel like scheme to do remote SKB queueing?
>
> PAGE_SIZE queue arrays, lockless access to head and tail pointers, and
> if queue is full we local free.
>
> I think that's a reasonable policy and the only detail to work out is
> to make sure we never race on the IPI send and thus miss processing
> the queue.
>
> What do you think?
>
Thats good ideas David, I'll work on them next week, and do benchmarks as well
before sending a new version.
Thanks
prev parent reply other threads:[~2009-11-20 22:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-19 23:46 [PATCH net-next-2.6] net: Xmit Packet Steering (XPS) Eric Dumazet
2009-11-20 2:12 ` Changli Gao
2009-11-20 4:58 ` Eric Dumazet
2009-11-20 5:11 ` Changli Gao
2009-11-20 5:24 ` Eric Dumazet
2009-11-20 5:34 ` Changli Gao
2009-11-20 5:42 ` Eric Dumazet
2009-11-20 5:50 ` Changli Gao
[not found] ` <65634d660911191641o4210a797mf1e8168dd8dd8b60@mail.gmail.com>
2009-11-20 5:08 ` Eric Dumazet
2009-11-20 13:32 ` Jarek Poplawski
2009-11-20 14:45 ` Eric Dumazet
2009-11-20 20:04 ` Jarek Poplawski
2009-11-20 21:43 ` Eric Dumazet
2009-11-20 22:08 ` Jarek Poplawski
2009-11-20 22:21 ` Eric Dumazet
2009-11-20 20:51 ` Andi Kleen
2009-11-20 20:53 ` David Miller
2009-11-20 22:30 ` Eric Dumazet
2009-11-20 22:37 ` Andi Kleen
[not found] ` <65634d660911201642k3930dc78vd576e0e89dc0c794@mail.gmail.com>
2009-11-21 6:58 ` Eric Dumazet
2009-11-20 20:53 ` Jarek Poplawski
2009-11-20 21:35 ` Eric Dumazet
2009-11-20 21:43 ` Joe Perches
2009-11-20 21:49 ` David Miller
2009-11-20 22:01 ` Eric Dumazet
2009-11-20 22:34 ` David Miller
2009-11-20 22:32 ` David Miller
2009-11-20 22:36 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0719E6.4060402@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).