* [PATCH net-next] drivers/isdn/gigaset: tasklet_init - Remove unnecessary leading & from second arg
@ 2009-11-19 19:55 Joe Perches
2009-11-19 20:29 ` David Miller
2009-11-21 18:08 ` Tilman Schmidt
0 siblings, 2 replies; 3+ messages in thread
From: Joe Perches @ 2009-11-19 19:55 UTC (permalink / raw)
To: David Miller
Cc: netdev, Hansjoerg Lipp, Tilman Schmidt, Karsten Keil,
gigaset307x-common
Changed function pointer use from non-majority address-of style
to majority short form without & via:
grep -rPl "\btasklet_init\s*\([^,\)]+,\s*\&" drivers/isdn | while read file ; do \
perl -i -e 'local $/; while (<>) { s@(\btasklet_init\s*\([^,\)]+,\s*)\&@\1@g ; print ; }' $file ;\
done
Compile tested allyesconfig x86
Signed-off-by: Joe Perches <joe@perches.com>
drivers/isdn/gigaset/bas-gigaset.c | 4 ++--
drivers/isdn/gigaset/common.c | 2 +-
drivers/isdn/gigaset/interface.c | 2 +-
drivers/isdn/gigaset/ser-gigaset.c | 2 +-
drivers/isdn/gigaset/usb-gigaset.c | 2 +-
5 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/isdn/gigaset/bas-gigaset.c b/drivers/isdn/gigaset/bas-gigaset.c
index 9fd19db..95ebc51 100644
--- a/drivers/isdn/gigaset/bas-gigaset.c
+++ b/drivers/isdn/gigaset/bas-gigaset.c
@@ -2117,7 +2117,7 @@ static int gigaset_initbcshw(struct bc_state *bcs)
return 0;
}
tasklet_init(&ubc->sent_tasklet,
- &write_iso_tasklet, (unsigned long) bcs);
+ write_iso_tasklet, (unsigned long) bcs);
spin_lock_init(&ubc->isoinlock);
for (i = 0; i < BAS_INURBS; ++i)
@@ -2138,7 +2138,7 @@ static int gigaset_initbcshw(struct bc_state *bcs)
ubc->shared0s = 0;
ubc->stolen0s = 0;
tasklet_init(&ubc->rcvd_tasklet,
- &read_iso_tasklet, (unsigned long) bcs);
+ read_iso_tasklet, (unsigned long) bcs);
return 1;
}
diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c
index c438cfc..82ed1cd 100644
--- a/drivers/isdn/gigaset/common.c
+++ b/drivers/isdn/gigaset/common.c
@@ -727,7 +727,7 @@ struct cardstate *gigaset_initcs(struct gigaset_driver *drv, int channels,
cs->ev_tail = 0;
cs->ev_head = 0;
- tasklet_init(&cs->event_tasklet, &gigaset_handle_event,
+ tasklet_init(&cs->event_tasklet, gigaset_handle_event,
(unsigned long) cs);
cs->commands_pending = 0;
cs->cur_at_seq = 0;
diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c
index 577809c..d2260b0 100644
--- a/drivers/isdn/gigaset/interface.c
+++ b/drivers/isdn/gigaset/interface.c
@@ -584,7 +584,7 @@ void gigaset_if_init(struct cardstate *cs)
if (!drv->have_tty)
return;
- tasklet_init(&cs->if_wake_tasklet, &if_wake, (unsigned long) cs);
+ tasklet_init(&cs->if_wake_tasklet, if_wake, (unsigned long) cs);
mutex_lock(&cs->mutex);
cs->tty_dev = tty_register_device(drv->tty, cs->minor_index, NULL);
diff --git a/drivers/isdn/gigaset/ser-gigaset.c b/drivers/isdn/gigaset/ser-gigaset.c
index ac3409e..168d585 100644
--- a/drivers/isdn/gigaset/ser-gigaset.c
+++ b/drivers/isdn/gigaset/ser-gigaset.c
@@ -434,7 +434,7 @@ static int gigaset_initcshw(struct cardstate *cs)
dev_set_drvdata(&cs->hw.ser->dev.dev, cs);
tasklet_init(&cs->write_tasklet,
- &gigaset_modem_fill, (unsigned long) cs);
+ gigaset_modem_fill, (unsigned long) cs);
return 1;
}
diff --git a/drivers/isdn/gigaset/usb-gigaset.c b/drivers/isdn/gigaset/usb-gigaset.c
index f56b2a8..3ab1dae 100644
--- a/drivers/isdn/gigaset/usb-gigaset.c
+++ b/drivers/isdn/gigaset/usb-gigaset.c
@@ -614,7 +614,7 @@ static int gigaset_initcshw(struct cardstate *cs)
ucs->bulk_out_urb = NULL;
ucs->read_urb = NULL;
tasklet_init(&cs->write_tasklet,
- &gigaset_modem_fill, (unsigned long) cs);
+ gigaset_modem_fill, (unsigned long) cs);
return 1;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] drivers/isdn/gigaset: tasklet_init - Remove unnecessary leading & from second arg
2009-11-19 19:55 [PATCH net-next] drivers/isdn/gigaset: tasklet_init - Remove unnecessary leading & from second arg Joe Perches
@ 2009-11-19 20:29 ` David Miller
2009-11-21 18:08 ` Tilman Schmidt
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2009-11-19 20:29 UTC (permalink / raw)
To: joe; +Cc: netdev, hjlipp, tilman, isdn, gigaset307x-common
From: Joe Perches <joe@perches.com>
Date: Thu, 19 Nov 2009 11:55:53 -0800
> Changed function pointer use from non-majority address-of style
> to majority short form without & via:
>
> grep -rPl "\btasklet_init\s*\([^,\)]+,\s*\&" drivers/isdn | while read file ; do \
> perl -i -e 'local $/; while (<>) { s@(\btasklet_init\s*\([^,\)]+,\s*)\&@\1@g ; print ; }' $file ;\
> done
>
> Compile tested allyesconfig x86
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] drivers/isdn/gigaset: tasklet_init - Remove unnecessary leading & from second arg
2009-11-19 19:55 [PATCH net-next] drivers/isdn/gigaset: tasklet_init - Remove unnecessary leading & from second arg Joe Perches
2009-11-19 20:29 ` David Miller
@ 2009-11-21 18:08 ` Tilman Schmidt
1 sibling, 0 replies; 3+ messages in thread
From: Tilman Schmidt @ 2009-11-21 18:08 UTC (permalink / raw)
To: Joe Perches
Cc: David Miller, netdev, Hansjoerg Lipp, Karsten Keil,
gigaset307x-common
[-- Attachment #1: Type: text/plain, Size: 3970 bytes --]
Am 19.11.2009 20:55 schrieb Joe Perches:
> Changed function pointer use from non-majority address-of style
> to majority short form without & via:
>
> grep -rPl "\btasklet_init\s*\([^,\)]+,\s*\&" drivers/isdn | while read file ; do \
> perl -i -e 'local $/; while (<>) { s@(\btasklet_init\s*\([^,\)]+,\s*)\&@\1@g ; print ; }' $file ;\
> done
>
> Compile tested allyesconfig x86
>
> Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: Tilman Schmidt <tilman@imap.cc>
Thanks,
Tilman
>
> drivers/isdn/gigaset/bas-gigaset.c | 4 ++--
> drivers/isdn/gigaset/common.c | 2 +-
> drivers/isdn/gigaset/interface.c | 2 +-
> drivers/isdn/gigaset/ser-gigaset.c | 2 +-
> drivers/isdn/gigaset/usb-gigaset.c | 2 +-
> 5 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/isdn/gigaset/bas-gigaset.c b/drivers/isdn/gigaset/bas-gigaset.c
> index 9fd19db..95ebc51 100644
> --- a/drivers/isdn/gigaset/bas-gigaset.c
> +++ b/drivers/isdn/gigaset/bas-gigaset.c
> @@ -2117,7 +2117,7 @@ static int gigaset_initbcshw(struct bc_state *bcs)
> return 0;
> }
> tasklet_init(&ubc->sent_tasklet,
> - &write_iso_tasklet, (unsigned long) bcs);
> + write_iso_tasklet, (unsigned long) bcs);
>
> spin_lock_init(&ubc->isoinlock);
> for (i = 0; i < BAS_INURBS; ++i)
> @@ -2138,7 +2138,7 @@ static int gigaset_initbcshw(struct bc_state *bcs)
> ubc->shared0s = 0;
> ubc->stolen0s = 0;
> tasklet_init(&ubc->rcvd_tasklet,
> - &read_iso_tasklet, (unsigned long) bcs);
> + read_iso_tasklet, (unsigned long) bcs);
> return 1;
> }
>
> diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c
> index c438cfc..82ed1cd 100644
> --- a/drivers/isdn/gigaset/common.c
> +++ b/drivers/isdn/gigaset/common.c
> @@ -727,7 +727,7 @@ struct cardstate *gigaset_initcs(struct gigaset_driver *drv, int channels,
> cs->ev_tail = 0;
> cs->ev_head = 0;
>
> - tasklet_init(&cs->event_tasklet, &gigaset_handle_event,
> + tasklet_init(&cs->event_tasklet, gigaset_handle_event,
> (unsigned long) cs);
> cs->commands_pending = 0;
> cs->cur_at_seq = 0;
> diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c
> index 577809c..d2260b0 100644
> --- a/drivers/isdn/gigaset/interface.c
> +++ b/drivers/isdn/gigaset/interface.c
> @@ -584,7 +584,7 @@ void gigaset_if_init(struct cardstate *cs)
> if (!drv->have_tty)
> return;
>
> - tasklet_init(&cs->if_wake_tasklet, &if_wake, (unsigned long) cs);
> + tasklet_init(&cs->if_wake_tasklet, if_wake, (unsigned long) cs);
>
> mutex_lock(&cs->mutex);
> cs->tty_dev = tty_register_device(drv->tty, cs->minor_index, NULL);
> diff --git a/drivers/isdn/gigaset/ser-gigaset.c b/drivers/isdn/gigaset/ser-gigaset.c
> index ac3409e..168d585 100644
> --- a/drivers/isdn/gigaset/ser-gigaset.c
> +++ b/drivers/isdn/gigaset/ser-gigaset.c
> @@ -434,7 +434,7 @@ static int gigaset_initcshw(struct cardstate *cs)
> dev_set_drvdata(&cs->hw.ser->dev.dev, cs);
>
> tasklet_init(&cs->write_tasklet,
> - &gigaset_modem_fill, (unsigned long) cs);
> + gigaset_modem_fill, (unsigned long) cs);
> return 1;
> }
>
> diff --git a/drivers/isdn/gigaset/usb-gigaset.c b/drivers/isdn/gigaset/usb-gigaset.c
> index f56b2a8..3ab1dae 100644
> --- a/drivers/isdn/gigaset/usb-gigaset.c
> +++ b/drivers/isdn/gigaset/usb-gigaset.c
> @@ -614,7 +614,7 @@ static int gigaset_initcshw(struct cardstate *cs)
> ucs->bulk_out_urb = NULL;
> ucs->read_urb = NULL;
> tasklet_init(&cs->write_tasklet,
> - &gigaset_modem_fill, (unsigned long) cs);
> + gigaset_modem_fill, (unsigned long) cs);
>
> return 1;
> }
>
>
--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-21 18:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-19 19:55 [PATCH net-next] drivers/isdn/gigaset: tasklet_init - Remove unnecessary leading & from second arg Joe Perches
2009-11-19 20:29 ` David Miller
2009-11-21 18:08 ` Tilman Schmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).