From: Franco Fichtner <franco@lastsummer.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Roland Dreier <rolandd@cisco.com>,
Yevgeny Petrilin <yevgenyp@mellanox.co.il>,
Yang Hongyang <yanghy@cn.fujitsu.com>,
Jack Morgenstein <jackm@dev.mellanox.co.il>,
Eli Cohen <eli@mellanox.co.il>,
netdev@vger.kernel.org
Subject: Re: [PATCH 10/38] don't wrap mlx4_remove_one in __devexit_p
Date: Wed, 25 Nov 2009 10:19:01 +0100 [thread overview]
Message-ID: <4B0CF685.6060208@lastsummer.de> (raw)
In-Reply-To: <1259096853-18909-10-git-send-email-u.kleine-koenig@pengutronix.de>
Uwe Kleine-König wrote:
> diff --git a/drivers/net/mlx4/main.c b/drivers/net/mlx4/main.c
> index 291a505..a581860 100644
> --- a/drivers/net/mlx4/main.c
> +++ b/drivers/net/mlx4/main.c
> @@ -1293,7 +1293,7 @@ static struct pci_driver mlx4_driver = {
> .name = DRV_NAME,
> .id_table = mlx4_pci_table,
> .probe = mlx4_init_one,
> - .remove = __devexit_p(mlx4_remove_one)
> + .remove = mlx4_remove_one
>
You may want to add the trailing comma while you're at it...
> };
>
> static int __init mlx4_verify_params(void)
>
f
next prev parent reply other threads:[~2009-11-25 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1259096853-18909-1-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-2-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-3-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-4-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-5-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-6-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-7-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-8-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-9-git-send-email-u.kleine-koenig@pengutronix.de>
2009-11-24 21:07 ` [PATCH 10/38] don't wrap mlx4_remove_one in __devexit_p Uwe Kleine-König
2009-11-25 9:19 ` Franco Fichtner [this message]
2009-11-25 9:23 ` [PATCH] " Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B0CF685.6060208@lastsummer.de \
--to=franco@lastsummer.de \
--cc=akpm@linux-foundation.org \
--cc=eli@mellanox.co.il \
--cc=jackm@dev.mellanox.co.il \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rolandd@cisco.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=yanghy@cn.fujitsu.com \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).