* [PATCH 10/38] don't wrap mlx4_remove_one in __devexit_p [not found] ` <1259096853-18909-9-git-send-email-u.kleine-koenig@pengutronix.de> @ 2009-11-24 21:07 ` Uwe Kleine-König 2009-11-25 9:19 ` Franco Fichtner 0 siblings, 1 reply; 3+ messages in thread From: Uwe Kleine-König @ 2009-11-24 21:07 UTC (permalink / raw) To: linux-kernel Cc: akpm, Roland Dreier, Yevgeny Petrilin, Yang Hongyang, Jack Morgenstein, Eli Cohen, netdev The function mlx4_remove_one is defined in .text, so there is no need to wrap it with __devexit_p. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Cc: Roland Dreier <rolandd@cisco.com> Cc: Yevgeny Petrilin <yevgenyp@mellanox.co.il> Cc: Yang Hongyang <yanghy@cn.fujitsu.com> Cc: Jack Morgenstein <jackm@dev.mellanox.co.il> Cc: Eli Cohen <eli@mellanox.co.il> Cc: linux-kernel@vger.kernel.org Cc: Andrew Morton <akpm@linux-foundation.org> Cc: netdev@vger.kernel.org --- drivers/net/mlx4/main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/mlx4/main.c b/drivers/net/mlx4/main.c index 291a505..a581860 100644 --- a/drivers/net/mlx4/main.c +++ b/drivers/net/mlx4/main.c @@ -1293,7 +1293,7 @@ static struct pci_driver mlx4_driver = { .name = DRV_NAME, .id_table = mlx4_pci_table, .probe = mlx4_init_one, - .remove = __devexit_p(mlx4_remove_one) + .remove = mlx4_remove_one }; static int __init mlx4_verify_params(void) -- 1.6.5.2 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 10/38] don't wrap mlx4_remove_one in __devexit_p 2009-11-24 21:07 ` [PATCH 10/38] don't wrap mlx4_remove_one in __devexit_p Uwe Kleine-König @ 2009-11-25 9:19 ` Franco Fichtner 2009-11-25 9:23 ` [PATCH] " Uwe Kleine-König 0 siblings, 1 reply; 3+ messages in thread From: Franco Fichtner @ 2009-11-25 9:19 UTC (permalink / raw) To: Uwe Kleine-König Cc: linux-kernel, akpm, Roland Dreier, Yevgeny Petrilin, Yang Hongyang, Jack Morgenstein, Eli Cohen, netdev Uwe Kleine-König wrote: > diff --git a/drivers/net/mlx4/main.c b/drivers/net/mlx4/main.c > index 291a505..a581860 100644 > --- a/drivers/net/mlx4/main.c > +++ b/drivers/net/mlx4/main.c > @@ -1293,7 +1293,7 @@ static struct pci_driver mlx4_driver = { > .name = DRV_NAME, > .id_table = mlx4_pci_table, > .probe = mlx4_init_one, > - .remove = __devexit_p(mlx4_remove_one) > + .remove = mlx4_remove_one > You may want to add the trailing comma while you're at it... > }; > > static int __init mlx4_verify_params(void) > f ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] don't wrap mlx4_remove_one in __devexit_p 2009-11-25 9:19 ` Franco Fichtner @ 2009-11-25 9:23 ` Uwe Kleine-König 0 siblings, 0 replies; 3+ messages in thread From: Uwe Kleine-König @ 2009-11-25 9:23 UTC (permalink / raw) To: linux-kernel Cc: Roland Dreier, Yevgeny Petrilin, Yang Hongyang, Jack Morgenstein, Eli Cohen, Andrew Morton, netdev, Franco Fichtner The function mlx4_remove_one is defined in .text, so there is no need to wrap it with __devexit_p. While at it add a trailing comma to the section initializer. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Cc: Roland Dreier <rolandd@cisco.com> Cc: Yevgeny Petrilin <yevgenyp@mellanox.co.il> Cc: Yang Hongyang <yanghy@cn.fujitsu.com> Cc: Jack Morgenstein <jackm@dev.mellanox.co.il> Cc: Eli Cohen <eli@mellanox.co.il> Cc: linux-kernel@vger.kernel.org Cc: Andrew Morton <akpm@linux-foundation.org> Cc: netdev@vger.kernel.org Cc: Franco Fichtner <franco@lastsummer.de> --- drivers/net/mlx4/main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/mlx4/main.c b/drivers/net/mlx4/main.c index 291a505..acc2878 100644 --- a/drivers/net/mlx4/main.c +++ b/drivers/net/mlx4/main.c @@ -1293,7 +1293,7 @@ static struct pci_driver mlx4_driver = { .name = DRV_NAME, .id_table = mlx4_pci_table, .probe = mlx4_init_one, - .remove = __devexit_p(mlx4_remove_one) + .remove = mlx4_remove_one, }; static int __init mlx4_verify_params(void) ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-25 9:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1259096853-18909-1-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-2-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-3-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-4-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-5-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-6-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-7-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-8-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1259096853-18909-9-git-send-email-u.kleine-koenig@pengutronix.de>
2009-11-24 21:07 ` [PATCH 10/38] don't wrap mlx4_remove_one in __devexit_p Uwe Kleine-König
2009-11-25 9:19 ` Franco Fichtner
2009-11-25 9:23 ` [PATCH] " Uwe Kleine-König
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).