Re: [PATCH] bnx2: avoid flushing statistics when doing a MTU change

[Eric Dumazet <eric.dumazet@gmail.com>]

Michael Chan a écrit :
> Eric Dumazet wrote:
> 
>> leitao@linux.vnet.ibm.com a écrit :
>>> Actually when bnx2 changes the interface's MTU size, it resets
>>> the chip and consequently flushes the interface statistics.
>>> This patch saves the statistics in a temporary space in order to
>>> maintain the statistics correct after the chip reset.
>>>
>>> Signed-off-by: Breno Leitao<leitao@linux.vnet.ibm.com>
>>
>>
>>>     return net_stats;
>>>  }
>>> @@ -6989,6 +7004,11 @@ bnx2_change_ring_size(struct bnx2
>> *bp, u32 rx, u32 tx)
>>>  {
>>>     if (netif_running(bp->dev)) {
>>>             bnx2_netif_stop(bp);
>> I wonder if you need to renew this stats before copying them ?
>>  (eg calling bnx2_get_stats())
> 
> Calling bnx2_get_stats() won't refresh the stats counters because
> they are DMA'ed once a second.  There's an I/O to immediately DMA
> the counters:
> 
> REG_WR(bp, BNX2_HC_COMMAND, bp->hc_cmd |
>                                 BNX2_HC_COMMAND_STATS_NOW);
> REG_RD(bp, BNX2_HC_COMMAND);
> 
> We then need to add some delay to wait for the DMA to complete.

Yes, but if you dont call bnx2_get_stats() netdev->stats will contain
possibly very old values.

At least, calling it will give one no more than second error.