From: Eric Dumazet <eric.dumazet@gmail.com>
To: Breno Leitao <leitao@linux.vnet.ibm.com>
Cc: Michael Chan <mchan@broadcom.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] bnx2: avoid flushing statistics when doing a MTU change
Date: Mon, 30 Nov 2009 14:32:55 +0100 [thread overview]
Message-ID: <4B13C987.3090409@gmail.com> (raw)
In-Reply-To: <4B13C5FE.7060403@linux.vnet.ibm.com>
Breno Leitao a écrit :
if (netif_running(bp->dev)) {
> bnx2_netif_stop(bp);
> +
> + /* Save statistics that is going to be reseted */
> + REG_WR(bp, BNX2_HC_COMMAND, bp->hc_cmd |
> + BNX2_HC_COMMAND_STATS_NOW);
> + REG_RD(bp, BNX2_HC_COMMAND);
> + udelay(5);
I see nothing in the driver/patch that will consolidate bp->dev->stats
before your memcpy(). DMA transfert doesnt touch bp->dev->stats.
Please take a look at bnx2_get_stats()
> + memcpy(&bp->stats_extra, &bp->dev->stats,
> + sizeof(struct net_device_stats));
> +
> bnx2_reset_chip(bp, BNX2_DRV_MSG_CODE_RESET);
next prev parent reply other threads:[~2009-11-30 13:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-27 16:59 [PATCH] bnx2: avoid flushing statistics when doing a MTU change leitao
2009-11-30 9:20 ` Michael Chan
2009-11-30 10:30 ` Eric Dumazet
2009-11-30 10:43 ` Michael Chan
2009-11-30 10:49 ` Eric Dumazet
2009-11-30 11:02 ` Michael Chan
2009-11-30 13:17 ` Breno Leitao
2009-11-30 13:32 ` Eric Dumazet [this message]
2009-11-30 14:05 ` Breno Leitao
2009-11-30 18:09 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B13C987.3090409@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=leitao@linux.vnet.ibm.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).