netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next-2.6] ieee802154: merge cleanup
       [not found] <20091130.010520.56312368.davem@davemloft.net>
@ 2009-12-01  3:59 ` Eric Dumazet
  2009-12-01  5:55   ` David Miller
  0 siblings, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2009-12-01  3:59 UTC (permalink / raw)
  To: David Miller; +Cc: Linux Netdev List

A small cleanup after last net-2.6 merge into net-next-2.6

As we are going to free skb, no need to set skb->skb_iif or skb->dev

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
 drivers/ieee802154/fakehard.c |    3 ---
 1 files changed, 3 deletions(-)

diff --git a/drivers/ieee802154/fakehard.c b/drivers/ieee802154/fakehard.c
index 5f67540..d9d0e13 100644
--- a/drivers/ieee802154/fakehard.c
+++ b/drivers/ieee802154/fakehard.c
@@ -282,9 +282,6 @@ static int ieee802154_fake_close(struct net_device *dev)
 static netdev_tx_t ieee802154_fake_xmit(struct sk_buff *skb,
                                              struct net_device *dev)
 {
-       skb->skb_iif = dev->ifindex;
-       skb->dev = dev;
-
        dev->stats.tx_packets++;
        dev->stats.tx_bytes += skb->len;


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next-2.6] ieee802154: merge cleanup
  2009-12-01  3:59 ` [PATCH net-next-2.6] ieee802154: merge cleanup Eric Dumazet
@ 2009-12-01  5:55   ` David Miller
  2009-12-01  6:05     ` Eric Dumazet
  0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2009-12-01  5:55 UTC (permalink / raw)
  To: eric.dumazet; +Cc: netdev

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 01 Dec 2009 04:59:20 +0100

> A small cleanup after last net-2.6 merge into net-next-2.6
> 
> As we are going to free skb, no need to set skb->skb_iif or skb->dev
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

-ECORRUPTEDPATCH

Are you really sure you want to keep using Thunderbird for
your email? :-)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next-2.6] ieee802154: merge cleanup
  2009-12-01  5:55   ` David Miller
@ 2009-12-01  6:05     ` Eric Dumazet
  2009-12-02  9:13       ` David Miller
  0 siblings, 1 reply; 4+ messages in thread
From: Eric Dumazet @ 2009-12-01  6:05 UTC (permalink / raw)
  To: David Miller; +Cc: netdev

David Miller a écrit :
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Tue, 01 Dec 2009 04:59:20 +0100
> 
>> A small cleanup after last net-2.6 merge into net-next-2.6
>>
>> As we are going to free skb, no need to set skb->skb_iif or skb->dev
>>
>> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> 
> -ECORRUPTEDPATCH
> 
> Are you really sure you want to keep using Thunderbird for
> your email? :-)

Sorry, my bad, sending patches at 4h30 am is error prone,
I did a stupid copy/paste from a wrong window.

[PATCH net-next-2.6] ieee802154: merge cleanup

A small cleanup after last net-2.6 merge into net-next-2.6

As we are going to free skb, no need to set skb->skb_iif or skb->dev

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
 drivers/ieee802154/fakehard.c |    3 ---
 1 files changed, 3 deletions(-)

diff --git a/drivers/ieee802154/fakehard.c b/drivers/ieee802154/fakehard.c
index 5f67540..d9d0e13 100644
--- a/drivers/ieee802154/fakehard.c
+++ b/drivers/ieee802154/fakehard.c
@@ -282,9 +282,6 @@ static int ieee802154_fake_close(struct net_device *dev)
 static netdev_tx_t ieee802154_fake_xmit(struct sk_buff *skb,
 					      struct net_device *dev)
 {
-	skb->skb_iif = dev->ifindex;
-	skb->dev = dev;
-
 	dev->stats.tx_packets++;
 	dev->stats.tx_bytes += skb->len;
 

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next-2.6] ieee802154: merge cleanup
  2009-12-01  6:05     ` Eric Dumazet
@ 2009-12-02  9:13       ` David Miller
  0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2009-12-02  9:13 UTC (permalink / raw)
  To: eric.dumazet; +Cc: netdev

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 01 Dec 2009 07:05:22 +0100

> [PATCH net-next-2.6] ieee802154: merge cleanup
> 
> A small cleanup after last net-2.6 merge into net-next-2.6
> 
> As we are going to free skb, no need to set skb->skb_iif or skb->dev
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-12-02  9:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20091130.010520.56312368.davem@davemloft.net>
2009-12-01  3:59 ` [PATCH net-next-2.6] ieee802154: merge cleanup Eric Dumazet
2009-12-01  5:55   ` David Miller
2009-12-01  6:05     ` Eric Dumazet
2009-12-02  9:13       ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).