Re: [RFC PATCH v3 0/8] CAIF Protocol Stack

[Stefano Babic <stefano.babic@babic.homelinux.org>]

sjur.brandeland@stericsson.com wrote:
> General:
> * Sockets has replaced the character device implementation,
>   when accessing the modem. AT channels has to open sockets.

Hi Sjur,

I would like to test your patches with real hardware (based on an ARM
processor), as I did last time before sending my comments.
I think it should easier if in the Documentation there is an example to
explain how to setup a connection, for example with AT protocol. I tried
and I get "Specified PHY type does not exists", probably because I have
not well understood the parameters.

There are some errors in the MAN page documentation (patch #7) and the
example reported does not compile (for example, CAIFSO_CHANNEL should be
CAIF_CHANNEL_OPT, and so on).

Can you provide an example for the user space to setup a connection ?

> Please check what you think of the asserts in this release and get back to be!

Yes, I will do it.

Best Regards,
Stefano

-- 
stefano <stefano.babic@babic.homelinux.org>
GPG Key: 0x55814DDE
Fingerprint 4E85 2A66 4CBA 497A 2A7B D3BF 5973 F216 5581 4DDE