linux-next: manual merge of the sysctl tree with the net tree

linux-next: manual merge of the sysctl tree with the net tree

[Stephen Rothwell]

Hi Eric,

Today's linux-next merge of the sysctl tree got a conflict in
net/ipv4/sysctl_net_ipv4.c between commit
519855c508b9a17878c0977a3cdefc09b59b30df ("TCPCT part 1c:
sysctl_tcp_cookie_size, socket option TCP_COOKIE_TRANSACTIONS") from the
net tree and commit f8572d8f2a2ba75408b97dc24ef47c83671795d7 ("sysctl
net: Remove unused binary sysctl code") from the sysctl tree.

I fixed it up (see below) and can carry the fix as necessary.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

diff --cc net/ipv4/sysctl_net_ipv4.c
index 13f7ab6,3000567..0000000
--- a/net/ipv4/sysctl_net_ipv4.c
+++ b/net/ipv4/sysctl_net_ipv4.c
@@@ -713,15 -569,6 +569,13 @@@ static struct ctl_table ipv4_table[] = 
  		.proc_handler	= proc_dointvec,
  	},
  	{
- 		.ctl_name	= CTL_UNNUMBERED,
 +		.procname	= "tcp_cookie_size",
 +		.data		= &sysctl_tcp_cookie_size,
 +		.maxlen		= sizeof(int),
 +		.mode		= 0644,
 +		.proc_handler	= proc_dointvec
 +	},
 +	{
- 		.ctl_name	= CTL_UNNUMBERED,
  		.procname	= "udp_mem",
  		.data		= &sysctl_udp_mem,
  		.maxlen		= sizeof(sysctl_udp_mem),

Re: linux-next: manual merge of the sysctl tree with the net tree

[William Allen Simpson]

Stephen Rothwell wrote:
> Hi Eric,
> 
> Today's linux-next merge of the sysctl tree got a conflict in
> net/ipv4/sysctl_net_ipv4.c between commit
> 519855c508b9a17878c0977a3cdefc09b59b30df ("TCPCT part 1c:
> sysctl_tcp_cookie_size, socket option TCP_COOKIE_TRANSACTIONS") from the
> net tree and commit f8572d8f2a2ba75408b97dc24ef47c83671795d7 ("sysctl
> net: Remove unused binary sysctl code") from the sysctl tree.
> 
> I fixed it up (see below) and can carry the fix as necessary.

Hi, I'm not Eric, but it's my TCPCT patch -- is there something more
that I need to do?

Adding a sysctl was my very first query to Linux lists.  I thought
everything was covered in that and subsequent threads.

    Subject: query: adding a sysctl
    Date: Fri, 02 Oct 2009 00:00:05 -0400

Re: linux-next: manual merge of the sysctl tree with the net tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

Hi William,

On Fri, 04 Dec 2009 07:16:35 -0500 William Allen Simpson <william.allen.simpson@gmail.com> wrote:
>
> Hi, I'm not Eric, but it's my TCPCT patch -- is there something more
> that I need to do?

No, at some point the maintainer of whichever tree gets merged last by
Linus will fix this up (or maybe Linus himself will).

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: manual merge of the sysctl tree with the net tree

[Eric W. Biederman]

William Allen Simpson <william.allen.simpson@gmail.com> writes:

> Stephen Rothwell wrote:
>> Hi Eric,
>>
>> Today's linux-next merge of the sysctl tree got a conflict in
>> net/ipv4/sysctl_net_ipv4.c between commit
>> 519855c508b9a17878c0977a3cdefc09b59b30df ("TCPCT part 1c:
>> sysctl_tcp_cookie_size, socket option TCP_COOKIE_TRANSACTIONS") from the
>> net tree and commit f8572d8f2a2ba75408b97dc24ef47c83671795d7 ("sysctl
>> net: Remove unused binary sysctl code") from the sysctl tree.
>>
>> I fixed it up (see below) and can carry the fix as necessary.
>
> Hi, I'm not Eric, but it's my TCPCT patch -- is there something more
> that I need to do?
>
> Adding a sysctl was my very first query to Linux lists.  I thought
> everything was covered in that and subsequent threads.

My apologies for not giving you a heads up earlier.

You initially ran into the problem in sysctl_check where you added a
new binary sysctl and you had errors.  That works to keep people from
adding new binary sysctl but as you experienced it is not the most
obvious way of communicating.

In my sysctl tree I have written a compatibility layer for all of the
existing binary sysctl handlers, and have removed the .ctl_name and
.strategy fields, that used to be used for implementing binary
sysctls.

In the best case scenario you could have seen that coming and not
included the .ctl_name line in your patch.  Then there would have been
a trivial conflict that would have required no changes to fixup.
However since I removed .ctl_name from before and after your new entry
a minor merge conflict was inevitable.

The price it seems for multiple independent development trees are the
occasionally conflicts in trees hosting kernel wide cleanups and fixes.

Eric

linux-next: manual merge of the sysctl tree with the net tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

Hi Eric,

Today's linux-next merge of the sysctl tree got a conflict in
kernel/sysctl_check.c between commit
8153a10c08f1312af563bb92532002e46d3f504a ("ipv4: add sysctl to accept
packets with local source addresses") from the net tree and commit
83ac201b4f06eb8aeb7ac93cf162651ba30e0b28 ("sysctl: Remove dead code from
sysctl_check") from the sysctl tree.

The latter removes the need for the former to change this file.  I just
used the latter.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: manual merge of the sysctl tree with the net tree

[Eric W. Biederman]

Stephen Rothwell <sfr@canb.auug.org.au> writes:

> Hi Eric,
>
> Today's linux-next merge of the sysctl tree got a conflict in
> kernel/sysctl_check.c between commit
> 8153a10c08f1312af563bb92532002e46d3f504a ("ipv4: add sysctl to accept
> packets with local source addresses") from the net tree and commit
> 83ac201b4f06eb8aeb7ac93cf162651ba30e0b28 ("sysctl: Remove dead code from
> sysctl_check") from the sysctl tree.
>
> The latter removes the need for the former to change this file.  I just
> used the latter.

Rats.  I feel blind.  I totally missed the fact that sysctl_check was
changed in that one.

Eric