[PATCH] myri10ge: use src+dst for rss hashing

[PATCH] myri10ge: use src+dst for rss hashing

[Brice Goglin]

Use a more effective rss hash by default (src + dst, rather than just src).

Signed-off-by: Brice Goglin <brice@myri.com>

--- net-next-2.6/drivers/net/myri10ge/myri10ge.c	2009-12-04 20:10:48.000000000 +0100
+++ linux-tmp/drivers/net/myri10ge/myri10ge.c	2009-12-04 20:57:15.000000000 +0100
@@ -75,7 +75,7 @@
 #include "myri10ge_mcp.h"
 #include "myri10ge_mcp_gen_header.h"
 
-#define MYRI10GE_VERSION_STR "1.5.1-1.451"
+#define MYRI10GE_VERSION_STR "1.5.1-1.453"
 
 MODULE_DESCRIPTION("Myricom 10G driver (10GbE)");
 MODULE_AUTHOR("Maintainer: help@myri.com");
@@ -347,7 +347,7 @@
 module_param(myri10ge_max_slices, int, S_IRUGO);
 MODULE_PARM_DESC(myri10ge_max_slices, "Max tx/rx queues");
 
-static int myri10ge_rss_hash = MXGEFW_RSS_HASH_TYPE_SRC_PORT;
+static int myri10ge_rss_hash = MXGEFW_RSS_HASH_TYPE_SRC_DST_PORT;
 module_param(myri10ge_rss_hash, int, S_IRUGO);
 MODULE_PARM_DESC(myri10ge_rss_hash, "Type of RSS hashing to do");
 

Re: [PATCH] myri10ge: use src+dst for rss hashing

[David Miller]

From: Brice Goglin <brice@myri.com>
Date: Fri, 04 Dec 2009 21:00:15 +0100

> Use a more effective rss hash by default (src + dst, rather than just src).
> 
> Signed-off-by: Brice Goglin <brice@myri.com>

Applied, but please get rid of this module parameter.

We have ethtool operations to configure this stuff, make
use of it instead of adding driver specific hacks.

Thank you.