From: Emese Revfy <re.emese@gmail.com>
To: yi.zhu@intel.com, reinette.chatre@intel.com, ilw@linux.intel.com,
linville@tuxdriver.com, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org, davem@da
Subject: Re: [PATCH 15/31] Constify struct iwl_ops for 2.6.32 v1
Date: Sat, 05 Dec 2009 00:05:47 +0100 [thread overview]
Message-ID: <4B1995CB.1050700@gmail.com> (raw)
In-Reply-To: <4B198DA7.1080809@gmail.com>
Added netdev@vger.kernel.org and davem@davemloft.net to CC.
> From: Emese Revfy <re.emese@gmail.com>
>
> Constify struct iwl_ops.
>
> Signed-off-by: Emese Revfy <re.emese@gmail.com>
> ---
> drivers/net/wireless/iwlwifi/iwl-1000.c | 2 +-
> drivers/net/wireless/iwlwifi/iwl-3945.c | 2 +-
> drivers/net/wireless/iwlwifi/iwl-4965.c | 2 +-
> drivers/net/wireless/iwlwifi/iwl-5000.c | 4 ++--
> drivers/net/wireless/iwlwifi/iwl-6000.c | 2 +-
> drivers/net/wireless/iwlwifi/iwl-dev.h | 2 +-
> 6 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-1000.c b/drivers/net/wireless/iwlwifi/iwl-1000.c
> index 950267a..80d5fd2 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-1000.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-1000.c
> @@ -137,7 +137,7 @@ static struct iwl_lib_ops iwl1000_lib = {
> },
> };
>
> -static struct iwl_ops iwl1000_ops = {
> +static const struct iwl_ops iwl1000_ops = {
> .ucode = &iwl5000_ucode,
> .lib = &iwl1000_lib,
> .hcmd = &iwl5000_hcmd,
> diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c
> index f059b49..fe90e0a 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-3945.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-3945.c
> @@ -2876,7 +2876,7 @@ static struct iwl_hcmd_utils_ops iwl3945_hcmd_utils = {
> .build_addsta_hcmd = iwl3945_build_addsta_hcmd,
> };
>
> -static struct iwl_ops iwl3945_ops = {
> +static const struct iwl_ops iwl3945_ops = {
> .ucode = &iwl3945_ucode,
> .lib = &iwl3945_lib,
> .hcmd = &iwl3945_hcmd,
> diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c b/drivers/net/wireless/iwlwifi/iwl-4965.c
> index 6f703a0..b7c4e48 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-4965.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-4965.c
> @@ -2335,7 +2335,7 @@ static struct iwl_lib_ops iwl4965_lib = {
> },
> };
>
> -static struct iwl_ops iwl4965_ops = {
> +static const struct iwl_ops iwl4965_ops = {
> .ucode = &iwl4965_ucode,
> .lib = &iwl4965_lib,
> .hcmd = &iwl4965_hcmd,
> diff --git a/drivers/net/wireless/iwlwifi/iwl-5000.c b/drivers/net/wireless/iwlwifi/iwl-5000.c
> index 6e6f516..0ec1f24 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-5000.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-5000.c
> @@ -1627,14 +1627,14 @@ static struct iwl_lib_ops iwl5150_lib = {
> },
> };
>
> -struct iwl_ops iwl5000_ops = {
> +const struct iwl_ops iwl5000_ops = {
> .ucode = &iwl5000_ucode,
> .lib = &iwl5000_lib,
> .hcmd = &iwl5000_hcmd,
> .utils = &iwl5000_hcmd_utils,
> };
>
> -static struct iwl_ops iwl5150_ops = {
> +static const struct iwl_ops iwl5150_ops = {
> .ucode = &iwl5000_ucode,
> .lib = &iwl5150_lib,
> .hcmd = &iwl5000_hcmd,
> diff --git a/drivers/net/wireless/iwlwifi/iwl-6000.c b/drivers/net/wireless/iwlwifi/iwl-6000.c
> index 1473452..f07d5e1 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-6000.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-6000.c
> @@ -146,7 +146,7 @@ static struct iwl_hcmd_utils_ops iwl6000_hcmd_utils = {
> .calc_rssi = iwl5000_calc_rssi,
> };
>
> -static struct iwl_ops iwl6000_ops = {
> +static const struct iwl_ops iwl6000_ops = {
> .ucode = &iwl5000_ucode,
> .lib = &iwl6000_lib,
> .hcmd = &iwl5000_hcmd,
> diff --git a/drivers/net/wireless/iwlwifi/iwl-dev.h b/drivers/net/wireless/iwlwifi/iwl-dev.h
> index 028d505..0c927e5 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-dev.h
> +++ b/drivers/net/wireless/iwlwifi/iwl-dev.h
> @@ -67,7 +67,7 @@ struct iwl_tx_queue;
>
> /* shared structures from iwl-5000.c */
> extern struct iwl_mod_params iwl50_mod_params;
> -extern struct iwl_ops iwl5000_ops;
> +extern const struct iwl_ops iwl5000_ops;
> extern struct iwl_ucode_ops iwl5000_ucode;
> extern struct iwl_lib_ops iwl5000_lib;
> extern struct iwl_hcmd_ops iwl5000_hcmd;
>
>
next prev parent reply other threads:[~2009-12-04 23:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4B198670.2000406@gmail.com>
[not found] ` <4B198A33.7080705@gmail.com>
2009-12-04 22:39 ` [PATCH 06/31] Constify struct e1000_mac_operations for 2.6.32 v1 Waskiewicz Jr, Peter P
2009-12-05 0:03 ` Emese Revfy
[not found] ` <4B19A337.6060808@gmail.com>
2009-12-05 0:40 ` Stephen Rothwell
2009-12-05 1:18 ` Emese Revfy
2009-12-05 1:21 ` Jeff Kirsher
[not found] ` <4B198FA1.7090807@gmail.com>
2009-12-04 23:02 ` [PATCH 22/31] Constify struct neigh_ops " Emese Revfy
2009-12-04 23:19 ` David Miller
2009-12-05 0:02 ` Emese Revfy
[not found] ` <4B198DA7.1080809@gmail.com>
2009-12-04 23:05 ` Emese Revfy [this message]
2009-12-05 0:02 ` [PATCH 15/31] Constify struct iwl_ops " Emese Revfy
[not found] ` <4B198AE3.2040003@gmail.com>
2009-12-04 22:40 ` [PATCH 08/31] Constify struct e1000_phy_operations " Waskiewicz Jr, Peter P
2009-12-05 0:03 ` Emese Revfy
[not found] ` <4B198A7E.4080407@gmail.com>
2009-12-04 22:40 ` [PATCH 07/31] Constify struct e1000_nvm_operations " Waskiewicz Jr, Peter P
2009-12-05 0:03 ` Emese Revfy
[not found] ` <4B1991E2.5010903@gmail.com>
2009-12-04 23:00 ` [PATCH 29/31] Constify struct sysfs_ops " Emese Revfy
2009-12-05 0:03 ` Emese Revfy
2009-12-05 21:15 ` Jens Axboe
2009-12-06 8:58 ` Pekka Enberg
2009-12-07 9:53 ` Hans J. Koch
[not found] ` <4B198C43.50205@gmail.com>
[not found] ` <4B19A333.5080103@gmail.com>
2009-12-05 0:09 ` [PATCH 11/31] Constify struct file_operations " Greg KH
2009-12-05 2:50 ` Emese Revfy
2009-12-05 4:15 ` Greg KH
2009-12-06 1:47 ` Emese Revfy
2009-12-06 17:25 ` Greg KH
2009-12-07 0:45 ` Emese Revfy
2009-12-07 15:11 ` Greg KH
2009-12-07 17:35 ` Emese Revfy
2009-12-07 17:57 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1995CB.1050700@gmail.com \
--to=re.emese@gmail.com \
--cc=davem@da \
--cc=ilw@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).