From: William Allen Simpson <william.allen.simpson@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Brice Goglin <brice@myri.com>, David Miller <davem@davemloft.net>,
netdev@vger.kernel.org,
Linux Kernel Developers <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next-2.6] drivers/net: Move && and || to end of previous line
Date: Sat, 05 Dec 2009 07:43:41 -0500 [thread overview]
Message-ID: <4B1A557D.4080707@gmail.com> (raw)
In-Reply-To: <1259947271.22783.120.camel@Joe-Laptop.home>
Joe Perches wrote:
> On Fri, 2009-12-04 at 14:10 +0100, Brice Goglin wrote:
>> Joe Perches wrote:
>>> Only files where David Miller is the primary git-signer.
>>> wireless, wimax, ixgbe, etc are not modified.
>> What's the point? Having them at the beginning of the next line is
>> easier to read from my point of view.
>
> It's just a stupid consistency thing.
>
Brice, I've made my objection known on the LKML. Joe *agrees* that
having them on the beginning of the line is preferred. Thousands of
contributors throughout the tree agree.
This is entirely a Miller thing.
My main objection to these sweeping patches is that it makes it much
more difficult to maintain and apply patches across different versions of
the tree. We have already seen conflicts with other git maintained trees.
These patches should not be accepted to the main Linus tree.
next prev parent reply other threads:[~2009-12-05 12:51 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-20 14:04 [net-next-2.6 PATCH v7 0/7 RFC] TCPCT part 1: cookie option exchange William Allen Simpson
2009-11-20 14:12 ` [net-next-2.6 PATCH v7 1/7 RFC] TCPCT part 1a: add request_values parameter for sending SYNACK William Allen Simpson
2009-11-20 17:20 ` David Miller
2009-11-20 14:23 ` [net-next-2.6 PATCH v7 2/7 RFC] TCPCT part 1b: generate Responder Cookie secret William Allen Simpson
2009-11-20 17:22 ` David Miller
2009-11-20 20:47 ` Andi Kleen
2009-11-20 20:51 ` David Miller
2009-11-21 16:09 ` William Allen Simpson
2009-11-20 14:33 ` [net-next-2.6 PATCH v7 3/7 RFC] TCPCT part 1c: sysctl_tcp_cookie_size, socket option TCP_COOKIE_TRANSACTIONS William Allen Simpson
2009-11-20 17:24 ` David Miller
2009-11-21 16:51 ` William Allen Simpson
2009-11-21 19:18 ` David Miller
2009-11-21 19:22 ` David Miller
2009-11-22 4:40 ` William Allen Simpson
2009-11-20 14:38 ` [net-next-2.6 PATCH v7 4/7 RFC] TCPCT part 1d: define TCP cookie option, extend existing struct's William Allen Simpson
2009-11-20 17:25 ` David Miller
2009-11-22 4:53 ` William Allen Simpson
2009-11-20 14:48 ` [net-next-2.6 PATCH v7 5/7 RFC] TCPCT part 1e: implement socket option TCP_COOKIE_TRANSACTIONS William Allen Simpson
2009-11-20 17:26 ` David Miller
2009-11-20 20:54 ` Joe Perches
2009-11-22 6:25 ` William Allen Simpson
2009-11-22 7:10 ` Joe Perches
2009-11-23 11:16 ` William Allen Simpson
2009-11-23 17:25 ` Joe Perches
2009-11-23 17:49 ` David Miller
2009-11-23 0:31 ` David Miller
2009-11-23 18:28 ` [net-next-2.6 PATCH] net/ipv4: Move && and || to end of previous line Joe Perches
2009-11-23 18:31 ` David Miller
2009-11-23 18:38 ` Joe Perches
2009-11-23 18:41 ` David Miller
2009-11-29 21:00 ` [PATCH net-next-2.6 PATCH] net: " Joe Perches
2009-11-30 0:55 ` David Miller
2009-11-30 17:28 ` Stephen Hemminger
2009-11-30 17:57 ` Joe Perches
2009-11-30 21:00 ` David Miller
2009-12-03 17:58 ` [PATCH net-next-2.6] drivers/net: " Joe Perches
2009-12-03 20:40 ` David Miller
2009-12-04 13:10 ` Brice Goglin
2009-12-04 17:21 ` Joe Perches
2009-12-05 12:43 ` William Allen Simpson [this message]
2009-12-05 17:50 ` Joe Perches
2009-12-05 22:05 ` Jarek Poplawski
2009-12-06 3:36 ` William Allen Simpson
2009-12-05 22:21 ` David Miller
2009-12-06 3:00 ` William Allen Simpson
2009-12-06 17:01 ` Jonathan Corbet
2009-12-04 22:42 ` David Miller
2009-11-23 22:08 ` [net-next-2.6 PATCH] net/ipv4: " Ilpo Järvinen
2009-11-23 22:14 ` Joe Perches
2009-11-23 22:32 ` Ilpo Järvinen
2009-11-23 18:58 ` [net-next-2.6 PATCH] net/ipv6: " Joe Perches
2009-11-24 22:53 ` David Miller
2009-11-23 19:49 ` [net-next-2.6 PATCH] net/ipv[46]/netfilter: " Joe Perches
2009-11-23 22:20 ` Patrick McHardy
2009-11-20 14:55 ` [net-next-2.6 PATCH v7 6/7 RFC] TCPCT part 1f: Initiator Cookie => Responder William Allen Simpson
2009-11-20 17:29 ` David Miller
2009-11-20 15:06 ` [net-next-2.6 PATCH v7 7/7 RFC] TCPCT part 1g: Responder Cookie => Initiator William Allen Simpson
2009-11-20 17:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1A557D.4080707@gmail.com \
--to=william.allen.simpson@gmail.com \
--cc=brice@myri.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).