From mboxrd@z Thu Jan 1 00:00:00 1970 From: Emese Revfy Subject: Re: [PATCH 11/31] Constify struct file_operations for 2.6.32 v1 Date: Sun, 06 Dec 2009 02:47:44 +0100 Message-ID: <4B1B0D40.3040209@gmail.com> References: <4B198670.2000406@gmail.com> <4B198C43.50205@gmail.com> <4B19A333.5080103@gmail.com> <20091205000942.GA8224@suse.de> <4B19CA6F.4090700@gmail.com> <20091205041507.GA24885@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: lenb@kernel.org, astarikovskiy@suse.de, mchehab@infradead.org, linville@tuxdriver.com, miklos@szeredi.hu, davem@davemloft.net, rostedt@goodmis.org, fweisbec@gmail.com, mingo@redhat.com, avi@redhat.com, mtosatti@redhat.com, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: Greg KH Return-path: Received: from mx2.mail.elte.hu ([157.181.151.9]:50270 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755349AbZLFBqa (ORCPT ); Sat, 5 Dec 2009 20:46:30 -0500 In-Reply-To: <20091205041507.GA24885@suse.de> Sender: netdev-owner@vger.kernel.org List-ID: Greg KH wrote: > On Sat, Dec 05, 2009 at 03:50:23AM +0100, Emese Revfy wrote: >> Greg KH wrote: >>> On Sat, Dec 05, 2009 at 01:02:59AM +0100, Emese Revfy wrote: >>>> -static struct file_operations ptmx_fops; >>>> +static const struct file_operations ptmx_fops = { >>>> + .llseek = no_llseek, >>>> + .read = tty_read, >>>> + .write = tty_write, >>>> + .poll = tty_poll, >>>> + .unlocked_ioctl = tty_ioctl, >>>> + .compat_ioctl = tty_compat_ioctl, >>>> + .open = ptmx_open, >>>> + .release = tty_release, >>>> + .fasync = tty_fasync, >>>> +}; >>> You just made these functions all global, for no real good reason. Why >>> did you do this? >> I think this is the only way to make ptmx_fops const, provided we want to. > > Why do we want to? Because I saw that checkpatch.pl itself tries to ensure the same I went through the whole tree looking for non-const file_operations structures and tried to make them const as best as I could. If you think making ptmx_fops const is not worth the effort I will remove it from the patch. -- Emese