From: Michal Marek <mmarek@suse.cz>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org,
Reinette Chatre <reinette.chatre@intel.com>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: linux-next: net/kbuild trees build failure
Date: Mon, 07 Dec 2009 13:22:50 +0100 [thread overview]
Message-ID: <4B1CF39A.5050806@suse.cz> (raw)
In-Reply-To: <20091207114158.GA2428@merkur.ravnborg.org>
On 7.12.2009 12:41, Sam Ravnborg wrote:
> On Mon, Dec 07, 2009 at 08:03:17PM +1100, Stephen Rothwell wrote:
>> Hi Dave,
>>
>> Today's linux-next build (powerpc allyesconfig) failed like this:
>>
>> In file included from drivers/net/wireless/iwlwifi/iwl3945-base.c:57:
>> drivers/net/wireless/iwlwifi/iwl-core.h:66:30: error: linux/utsrelease.h: No such file or directory
>>
>> Caused by commit 250cce26d5d03337aec4ff8405121f026adb4a89 ("iwlwifi:
>> driver version track kernel version") from the net tree interacting with
>> commit 8e5c76aace9705b6983cfbf5eb2f2e869dab6738 ("kbuild: move
>> utsrelease.h to include/generated") from the kbuild tree.
>>
>> I applied this patch for today (and will carry it as necessary):
>
> The right fix would be to use 'utsname()->sysname' (I think sysname
> is the right member).
->release would be the right one. One could also question why iwlwifi
needs to repeat the kernel version it was built / is running against,
but I that's not the point here :). Dave, John, can we agree that
whichever tree gets merged first, the other tree applies the one-liner?
Thanks!
Michal
next prev parent reply other threads:[~2009-12-07 12:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-07 9:03 linux-next: net/kbuild trees build failure Stephen Rothwell
2009-12-07 11:41 ` Sam Ravnborg
2009-12-07 12:22 ` Michal Marek [this message]
2009-12-07 16:09 ` John W. Linville
2009-12-07 18:12 ` reinette chatre
2009-12-07 21:42 ` Michal Marek
2009-12-07 22:04 ` reinette chatre
2009-12-07 22:28 ` John W. Linville
2009-12-08 5:38 ` Sam Ravnborg
2009-12-08 14:54 ` John W. Linville
2009-12-08 23:11 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1CF39A.5050806@suse.cz \
--to=mmarek@suse.cz \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=sam@ravnborg.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).