From: Eric Dumazet <eric.dumazet@gmail.com>
To: Krishna Kumar <krkumar2@in.ibm.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] net: release dst entry while cache-hot for GSO case too
Date: Thu, 10 Dec 2009 09:21:00 +0100 [thread overview]
Message-ID: <4B20AF6C.2060604@gmail.com> (raw)
In-Reply-To: <20091210065958.10261.89370.sendpatchset@localhost.localdomain>
Le 10/12/2009 07:59, Krishna Kumar a écrit :
> From: Krishna Kumar <krkumar2@in.ibm.com>
>
> Non-GSO code drops dst entry for performance reasons, but
> the same is missing for GSO code. Drop dst while cache-hot
> for GSO case too.
>
> Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
> ---
>
> diff -ruNp org/net/core/dev.c new/net/core/dev.c
> --- org/net/core/dev.c 2009-12-10 10:20:39.000000000 +0530
> +++ new/net/core/dev.c 2009-12-10 10:21:17.000000000 +0530
> @@ -1853,6 +1853,14 @@ gso:
>
> skb->next = nskb->next;
> nskb->next = NULL;
> +
> + /*
> + * If device doesnt need nskb->dst, release it right now while
> + * its hot in this cpu cache
> + */
> + if (dev->priv_flags & IFF_XMIT_DST_RELEASE)
> + skb_dst_drop(nskb);
> +
> rc = ops->ndo_start_xmit(nskb, dev);
> if (unlikely(rc != NETDEV_TX_OK)) {
> if (rc & ~NETDEV_TX_MASK)
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
next prev parent reply other threads:[~2009-12-10 8:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 6:59 [PATCH] net: release dst entry while cache-hot for GSO case too Krishna Kumar
2009-12-10 8:21 ` Eric Dumazet [this message]
2009-12-23 22:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B20AF6C.2060604@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=krkumar2@in.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).