From: Eric Dumazet <eric.dumazet@gmail.com>
To: Kumar Gopalpet-B05799 <B05799@freescale.com>
Cc: netdev@vger.kernel.org, avorontsov@ru.mvista.com, davem@davemloft.net
Subject: Re: [RFC] gianfar: Fix stats support
Date: Thu, 10 Dec 2009 09:21:58 +0100 [thread overview]
Message-ID: <4B20AFA6.80706@gmail.com> (raw)
In-Reply-To: <9F4C7D19E8361D4C94921B95BE08B81BA08AE5@zin33exm22.fsl.freescale.net>
Le 10/12/2009 08:43, Kumar Gopalpet-B05799 a écrit :
>
>> Fine by me, but if this patch is for linux-2.6.33, you can use
>> dev_txq_stats_fold() helper in your gfar_get_stats()
>>
>> dev_txq_stats_fold(dev, &dev->stats);
>> return &dev->stats;
>>
>
> Eric, the problem in using dev_txq_stats_fold() will be that
> txq->tx_dropped will not be updated. tx_dropped counter is updated on a
> device level in the gfar_error( ) interrupt context (here we do not know
> the txq index).
> So, if we use dev_txq_stats_fold(), we will incorrectly give the
> tx_dropped stats.
Ah yes, you are very right, thanks !
next prev parent reply other threads:[~2009-12-10 8:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 5:42 [RFC] gianfar: Fix stats support Sandeep Gopalpet
2009-12-10 6:13 ` Eric Dumazet
2009-12-10 7:43 ` Kumar Gopalpet-B05799
2009-12-10 8:21 ` Eric Dumazet [this message]
2009-12-10 8:25 ` Eric Dumazet
2009-12-10 15:11 ` Anton Vorontsov
2009-12-11 4:50 ` Kumar Gopalpet-B05799
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B20AFA6.80706@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=B05799@freescale.com \
--cc=avorontsov@ru.mvista.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).