From: William Allen Simpson <william.allen.simpson@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: davem@davemloft.net,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: + net-ipv4-tcpc-fix-warning.patch added to -mm tree
Date: Thu, 10 Dec 2009 08:48:30 -0500 [thread overview]
Message-ID: <4B20FC2E.7050809@gmail.com> (raw)
In-Reply-To: <20091208180801.88be28ba.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Tue, 08 Dec 2009 20:45:53 -0500
> William Allen Simpson <william.allen.simpson@gmail.com> wrote:
>> I didn't have this warning, how in the world do you get it?
>
> Used gcc-4.0.2. They re-randomise the warnings with each release I think.
>
Using gcc-4.4.1 here, and the usual 'make -s -j4 vmlinux'.
>> This is what David calls my "anal" coding style. I check everything,
>> because someday somebody else might make a change, and it's important
>> that such problems be detected. In this case, I assume the compiler
>> will compile them out or it would have no effect, and commented that
>> it should be impossible.
>>
>> Your test should probably be TCP_MSS_DEFAULT < TCP_COOKIE_PAIR_SIZE
>
> I'd say just delete it ;)
>
Well, David said he would, but nothing seems to have happened, so I'll
send a short patch in my next message.
next prev parent reply other threads:[~2009-12-10 13:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200912090045.nB90jTaO010647@imap1.linux-foundation.org>
2009-12-09 1:45 ` + net-ipv4-tcpc-fix-warning.patch added to -mm tree William Allen Simpson
2009-12-09 2:08 ` Andrew Morton
2009-12-09 4:07 ` David Miller
2009-12-10 13:48 ` William Allen Simpson [this message]
2009-12-10 14:16 ` [PATCH] net-ipv4-tcp.c-fix-warning-from-older-compilers.patch William Allen Simpson
2009-12-10 14:31 ` Ben Hutchings
2009-12-11 15:30 ` William Allen Simpson
2009-12-11 15:38 ` [PATCH v2] net-ipv4-tcp.c-fix-warning-for-older-compilers.patch William Allen Simpson
2009-12-10 15:31 ` [PATCH] net-ipv4-tcp.c-fix-warning-from-older-compilers.patch Eric Dumazet
2009-12-10 21:46 ` David Miller
2009-12-11 6:50 ` Jarek Poplawski
2009-12-11 15:51 ` William Allen Simpson
2009-12-11 19:25 ` Jarek Poplawski
2009-12-11 22:25 ` David Miller
2009-12-11 15:49 ` William Allen Simpson
2009-12-11 22:24 ` David Miller
2009-12-10 21:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B20FC2E.7050809@gmail.com \
--to=william.allen.simpson@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).