From: William Allen Simpson <william.allen.simpson@gmail.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
davem@davemloft.net,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH] net-ipv4-tcp.c-fix-warning-from-older-compilers.patch
Date: Fri, 11 Dec 2009 10:30:24 -0500 [thread overview]
Message-ID: <4B226590.6030608@gmail.com> (raw)
In-Reply-To: <1260455516.2783.0.camel@achroite.uk.solarflarecom.com>
Ben Hutchings wrote:
> You can use BUILD_BUG_ON() to ensure that remains true.
>
Another fine undocumented Linux Kernel feature. In the absence of
standardized functions that check for buffer overruns, that's just
the ticket!
Kinda the opposite conditional of static assert, but I'm pretty sure
static assert wasn't working in gcc until a year or so ago. That's
why I used the more old-fashioned test instead. I'd no idea those
triggered a warning in some versions of gcc -- I never trusted 4.0.x,
and had plenty of problems with 4.1.x, too.
Thanks, I'll resubmit.
next prev parent reply other threads:[~2009-12-11 15:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200912090045.nB90jTaO010647@imap1.linux-foundation.org>
2009-12-09 1:45 ` + net-ipv4-tcpc-fix-warning.patch added to -mm tree William Allen Simpson
2009-12-09 2:08 ` Andrew Morton
2009-12-09 4:07 ` David Miller
2009-12-10 13:48 ` William Allen Simpson
2009-12-10 14:16 ` [PATCH] net-ipv4-tcp.c-fix-warning-from-older-compilers.patch William Allen Simpson
2009-12-10 14:31 ` Ben Hutchings
2009-12-11 15:30 ` William Allen Simpson [this message]
2009-12-11 15:38 ` [PATCH v2] net-ipv4-tcp.c-fix-warning-for-older-compilers.patch William Allen Simpson
2009-12-10 15:31 ` [PATCH] net-ipv4-tcp.c-fix-warning-from-older-compilers.patch Eric Dumazet
2009-12-10 21:46 ` David Miller
2009-12-11 6:50 ` Jarek Poplawski
2009-12-11 15:51 ` William Allen Simpson
2009-12-11 19:25 ` Jarek Poplawski
2009-12-11 22:25 ` David Miller
2009-12-11 15:49 ` William Allen Simpson
2009-12-11 22:24 ` David Miller
2009-12-10 21:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B226590.6030608@gmail.com \
--to=william.allen.simpson@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).