From: Bernard Pidoux <bpidoux@free.fr>
To: Ralf Baechle DL5RB <ralf@linux-mips.org>,
David Miller <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: [PATCH] rose_loopback_timer VC number <= ROSE_DEFAULT_MAXVC
Date: Sat, 12 Dec 2009 09:56:02 +0100 [thread overview]
Message-ID: <4B235AA2.1040608@free.fr> (raw)
[PATCH] rose_loopback_timer VC number <= ROSE_DEFAULT_MAXVC
On my 2.6.32 kernel compiled for generic x86_64 CPU
cat /proc/net/rose displayed a rose sockets abnormal lci value, i.e. greater than maximum
number of VCs per neighbour allowed.
This out of limits number prevents further comparisons of lci value during rose VC attributions.
Example :
[bernard]# cat /proc/net/rose
dest_addr dest_call src_addr src_call dev lci neigh st vs vr va t t1 t2 t3 hb idle Snd-Q Rcv-Q inode
* * 2080175520 F6BVP-1 rose0 000 00000 0 0 0 0 0 200 180 180 5 0/000 0 0 254746
2080175520 FPAD-0 2080175520 WP-0 rose0 FFE 00001 3 0 0 0 0 200 180 180 5 0/000 0 0 12916
Here are the default parameters definitions :
linux/include/net/rose.h:#define ROSE_DEFAULT_MAXVC 50 /* Maximum number of VCs per neighbour */
linux/net/rose/af_rose.c:int sysctl_rose_maximum_vcs = ROSE_DEFAULT_MAXVC;
With the following patch, rose_loopback_timer() attributes a VC number within limits.
--- a/net/rose/rose_loopback.c 2009-12-03 04:51:21.000000000 +0100
+++ b/net/rose/rose_loopback.c 2009-12-06 23:17:02.267741413 +0100
@@ -75,7 +75,7 @@
lci_i = ((skb->data[0] << 8) & 0xF00) + ((skb->data[1] << 0) & 0x0FF);
frametype = skb->data[2];
dest = (rose_address *)(skb->data + 4);
- lci_o = 0xFFF - lci_i;
+ lci_o = ROSE_DEFAULT_MAXVC + 1 - lci_i;
skb_reset_transport_header(skb);
Bernard Pidoux
next reply other threads:[~2009-12-12 8:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-12 8:56 Bernard Pidoux [this message]
2009-12-14 3:38 ` [PATCH] rose_loopback_timer VC number <= ROSE_DEFAULT_MAXVC David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B235AA2.1040608@free.fr \
--to=bpidoux@free.fr \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).