* [PATCH] mlx4_core: return a negative error value
@ 2009-12-12 19:09 Roel Kluin
2009-12-14 3:48 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-12-12 19:09 UTC (permalink / raw)
To: netdev, yevgenyp, Andrew Morton, LKML
The return value should be negative.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
drivers/net/mlx4/sense.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
This is a cleanup, its only caller, mlx4_do_sense_ports()
acts on any non-zero error values as well.
diff --git a/drivers/net/mlx4/sense.c b/drivers/net/mlx4/sense.c
index f36ae69..015fbe7 100644
--- a/drivers/net/mlx4/sense.c
+++ b/drivers/net/mlx4/sense.c
@@ -53,7 +53,7 @@ static int mlx4_SENSE_PORT(struct mlx4_dev *dev, int port,
if (out_param > 2) {
mlx4_err(dev, "Sense returned illegal value: 0x%llx\n", out_param);
- return EINVAL;
+ return -EINVAL;
}
*type = out_param;
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-14 3:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-12 19:09 [PATCH] mlx4_core: return a negative error value Roel Kluin
2009-12-14 3:48 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).