From: Wolfgang Grandegger <wg@grandegger.com>
To: David Miller <davem@davemloft.net>
Cc: geert@linux-m68k.org, chripell@fsfe.org,
urs.thuermann@volkswagen.de, oliver.hartkopp@volkswagen.de,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: CAN_MCP251X should depend on HAS_DMA
Date: Mon, 14 Dec 2009 08:34:35 +0100 [thread overview]
Message-ID: <4B25EA8B.1030507@grandegger.com> (raw)
In-Reply-To: <20091213.174020.26980813.davem@davemloft.net>
David Miller wrote:
> From: Wolfgang Grandegger <wg@grandegger.com>
> Date: Sun, 13 Dec 2009 21:47:04 +0100
>
>> DMA can be selected with the module parameter "mcp251x_enable_dma" and
>> is *off* by default. Therefore the driver does in principle not depend
>> on HAS_DMA but I'm not sure if it's worth to handle it with #idef's.
>> Christian? Any thought?
>
> I still think it's a reasonable dependency.
>
> You're not going to find this device on a s390 system. :-)
OK, we could change that on request.
Wolfgang.
next prev parent reply other threads:[~2009-12-14 7:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-13 19:11 [PATCH] can: CAN_MCP251X should depend on HAS_DMA Geert Uytterhoeven
2009-12-13 20:47 ` Wolfgang Grandegger
2009-12-14 1:40 ` David Miller
2009-12-14 7:34 ` Wolfgang Grandegger [this message]
2009-12-14 8:14 ` christian pellegrin
2009-12-14 3:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B25EA8B.1030507@grandegger.com \
--to=wg@grandegger.com \
--cc=chripell@fsfe.org \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver.hartkopp@volkswagen.de \
--cc=urs.thuermann@volkswagen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).