* [PATCH] broadcom: bcm54xx_shadow_read() errors ignored in bcm54xx_adjust_rxrefclk()
@ 2009-12-16 13:02 Roel Kluin
2009-12-18 1:41 ` Matt Carlson
0 siblings, 1 reply; 3+ messages in thread
From: Roel Kluin @ 2009-12-16 13:02 UTC (permalink / raw)
To: netdev, mcarlson, Andrew Morton, LKML, davem
If not signed read errors are ignored.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Found using coccinelle: http://coccinelle.lip6.fr/
diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
index f63c96a..c13cf64 100644
--- a/drivers/net/phy/broadcom.c
+++ b/drivers/net/phy/broadcom.c
@@ -326,7 +326,8 @@ error:
static void bcm54xx_adjust_rxrefclk(struct phy_device *phydev)
{
- u32 val, orig;
+ u32 orig;
+ int val;
bool clk125en = true;
/* Abort if we are using an untested phy. */
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] broadcom: bcm54xx_shadow_read() errors ignored in bcm54xx_adjust_rxrefclk()
2009-12-16 13:02 [PATCH] broadcom: bcm54xx_shadow_read() errors ignored in bcm54xx_adjust_rxrefclk() Roel Kluin
@ 2009-12-18 1:41 ` Matt Carlson
2009-12-19 4:16 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Matt Carlson @ 2009-12-18 1:41 UTC (permalink / raw)
To: Roel Kluin
Cc: netdev@vger.kernel.org, Matthew Carlson, Andrew Morton, LKML,
davem@davemloft.net
On Wed, Dec 16, 2009 at 05:02:26AM -0800, Roel Kluin wrote:
> If not signed read errors are ignored.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Matt Carlson <mcarlson@broadcom.com>
> ---
> Found using coccinelle: http://coccinelle.lip6.fr/
>
> diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
> index f63c96a..c13cf64 100644
> --- a/drivers/net/phy/broadcom.c
> +++ b/drivers/net/phy/broadcom.c
> @@ -326,7 +326,8 @@ error:
>
> static void bcm54xx_adjust_rxrefclk(struct phy_device *phydev)
> {
> - u32 val, orig;
> + u32 orig;
> + int val;
> bool clk125en = true;
>
> /* Abort if we are using an untested phy. */
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] broadcom: bcm54xx_shadow_read() errors ignored in bcm54xx_adjust_rxrefclk()
2009-12-18 1:41 ` Matt Carlson
@ 2009-12-19 4:16 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-12-19 4:16 UTC (permalink / raw)
To: mcarlson; +Cc: roel.kluin, netdev, akpm, linux-kernel
From: "Matt Carlson" <mcarlson@broadcom.com>
Date: Thu, 17 Dec 2009 17:41:39 -0800
> On Wed, Dec 16, 2009 at 05:02:26AM -0800, Roel Kluin wrote:
>> If not signed read errors are ignored.
>>
>> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
>
> Acked-by: Matt Carlson <mcarlson@broadcom.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-19 4:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-16 13:02 [PATCH] broadcom: bcm54xx_shadow_read() errors ignored in bcm54xx_adjust_rxrefclk() Roel Kluin
2009-12-18 1:41 ` Matt Carlson
2009-12-19 4:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).