From: Wolfgang Grandegger <wg@grandegger.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, David Vrabel <dvrabel@arcom.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Urs Thuermann <urs.thuermann@volkswagen.de>,
Oliver Hartkopp <oliver.hartkopp@volkswagen.de>,
"David S. Miller" <davem@davemloft.net>,
Kurt Van Dijck <kurt.van.dijck@eia.be>,
netdev@vger.kernel.org
Subject: Re: [PATCH 4/7] can/at91: don't check platform_get_irq's return value against zero
Date: Wed, 16 Dec 2009 17:27:03 +0100 [thread overview]
Message-ID: <4B290A57.3010705@grandegger.com> (raw)
In-Reply-To: <1260979809-24811-4-git-send-email-u.kleine-koenig@pengutronix.de>
Uwe Kleine-König wrote:
> platform_get_irq returns -ENXIO on failure, so !irq was probably
> always true. Better use (int)irq <= 0. Note that a return value of
> zero is still handled as error even though this could mean irq0.
But only on ARM, which is the only platform still using the infamous
NO_IRQ (=-1). As this is a driver for ARM hardware, using irq == NO_IRQ
would make sense, though.
Wolfgang.
next prev parent reply other threads:[~2009-12-16 16:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1260979809-24811-1-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1260979809-24811-2-git-send-email-u.kleine-koenig@pengutronix.de>
[not found] ` <1260979809-24811-3-git-send-email-u.kleine-koenig@pengutronix.de>
2009-12-16 16:10 ` [PATCH 4/7] can/at91: don't check platform_get_irq's return value against zero Uwe Kleine-König
2009-12-16 16:27 ` Wolfgang Grandegger [this message]
2009-12-16 17:08 ` Uwe Kleine-König
2009-12-16 17:47 ` Alan Cox
2009-12-17 7:17 ` Wolfgang Grandegger
2009-12-16 18:57 ` Wolfgang Grandegger
2009-12-16 18:58 ` Wolfgang Grandegger
2009-12-19 4:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B290A57.3010705@grandegger.com \
--to=wg@grandegger.com \
--cc=davem@davemloft.net \
--cc=dvrabel@arcom.com \
--cc=gregkh@suse.de \
--cc=kurt.van.dijck@eia.be \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver.hartkopp@volkswagen.de \
--cc=u.kleine-koenig@pengutronix.de \
--cc=urs.thuermann@volkswagen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).