netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Octavian Purdila <opurdila@ixiacom.com>
Cc: Lucian Adrian Grijincu <lgrijincu@ixiacom.com>, netdev@vger.kernel.org
Subject: Re: [RFC 1/2] udp: add non-linear uniform port allocation scheme option /proc/sys/net/ipv4/udp_port_randomization
Date: Thu, 17 Dec 2009 17:00:12 +0100	[thread overview]
Message-ID: <4B2A558C.7080204@gmail.com> (raw)
In-Reply-To: <200912171716.56066.opurdila@ixiacom.com>

Le 17/12/2009 16:16, Octavian Purdila a écrit :

> Thanks for reviewing Eric. In this thread 
> 
> http://kerneltrap.org/mailarchive/linux-netdev/2009/5/8/5667204 (ports being 
> reused too fast)
> 
> Stephen observed that port randomization effects on same port allocation 
> frequency are explained by the birthday paradox. 

But this was with TCP, not UDP. Without NAT, UDP has no timewait concept.

> 
> The RFC suggesting port randomization recognizes this issue and suggest a way 
> to overcome it, but on a first glance it looks expensive. 
> 
> Adding a sysctl to sequencial port allocation might not be the best option, 
> but we thought of kicking the discussion about this issue with this patch.

Before sending patches, you might first describe the issue ?

> 
>> BTW, net-next-2.6 is not yet open, this is not the right time to submit non
>>  bug fixes patches.
> 
> Yes, we know that, but we are still learning the details. For instance, should 
> we refrain from sending RFC patches (as in patches we are not sure that are 
> right and want to get early feedback on) as well during the merge window?

You always *can* send RFC/patches, but we are pretty busy to correct bugs,
and take some free time to rest :=)

Thanks

  reply	other threads:[~2009-12-17 16:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-16 19:24 [RFC 1/2] udp: add non-linear uniform port allocation scheme option /proc/sys/net/ipv4/udp_port_randomization Lucian Adrian Grijincu
2009-12-17 14:07 ` Eric Dumazet
2009-12-17 15:16   ` Octavian Purdila
2009-12-17 16:00     ` Eric Dumazet [this message]
2009-12-18 13:12       ` Octavian Purdila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B2A558C.7080204@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=lgrijincu@ixiacom.com \
    --cc=netdev@vger.kernel.org \
    --cc=opurdila@ixiacom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).