* [net-2.6 PATCH 1/3] be2net: Bug fix to avoid soft lockup in loopback test.
@ 2009-12-23 14:40 Sarveshwar Bandi
2009-12-24 4:58 ` David Miller
2009-12-24 13:28 ` Jan Ceuleers
0 siblings, 2 replies; 4+ messages in thread
From: Sarveshwar Bandi @ 2009-12-23 14:40 UTC (permalink / raw)
To: netdev; +Cc: davem
This change ensures that loopback test command gives up after 4 seconds when
the hardware is not responsive. This could happen if the ports are connected
properly in loopback mode.
Signed-off-by: Sarveshwar Bandi <sarveshwarb@serverengines.com>
---
drivers/net/benet/be_cmds.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c
index 1b68bd9..a27fdb3 100644
--- a/drivers/net/benet/be_cmds.c
+++ b/drivers/net/benet/be_cmds.c
@@ -1501,6 +1501,7 @@ int be_cmd_loopback_test(struct be_adapt
be_cmd_hdr_prepare(&req->hdr, CMD_SUBSYSTEM_LOWLEVEL,
OPCODE_LOWLEVEL_LOOPBACK_TEST, sizeof(*req));
+ req->hdr.timeout = 4;
req->pattern = cpu_to_le64(pattern);
req->src_port = cpu_to_le32(port_num);
--
1.4.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [net-2.6 PATCH 1/3] be2net: Bug fix to avoid soft lockup in loopback test.
2009-12-23 14:40 [net-2.6 PATCH 1/3] be2net: Bug fix to avoid soft lockup in loopback test Sarveshwar Bandi
@ 2009-12-24 4:58 ` David Miller
2009-12-24 13:28 ` Jan Ceuleers
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2009-12-24 4:58 UTC (permalink / raw)
To: sarveshwarb; +Cc: netdev
From: Sarveshwar Bandi <sarveshwarb@serverengines.com>
Date: Wed, 23 Dec 2009 20:10:36 +0530
> This change ensures that loopback test command gives up after 4 seconds when
> the hardware is not responsive. This could happen if the ports are connected
> properly in loopback mode.
>
> Signed-off-by: Sarveshwar Bandi <sarveshwarb@serverengines.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [net-2.6 PATCH 1/3] be2net: Bug fix to avoid soft lockup in loopback test.
2009-12-23 14:40 [net-2.6 PATCH 1/3] be2net: Bug fix to avoid soft lockup in loopback test Sarveshwar Bandi
2009-12-24 4:58 ` David Miller
@ 2009-12-24 13:28 ` Jan Ceuleers
2009-12-24 17:42 ` Jan Ceuleers
1 sibling, 1 reply; 4+ messages in thread
From: Jan Ceuleers @ 2009-12-24 13:28 UTC (permalink / raw)
To: Sarveshwar Bandi; +Cc: netdev, davem
Sarveshwar Bandi wrote:
> This change ensures that loopback test command gives up after 4 seconds when
> the hardware is not responsive. This could happen if the ports are connected
> properly in loopback mode.
I don't understand the 2nd sentence, did you mean to say that this could happen if the ports are *not* connected properly in loopback mode?
Thanks, Jan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [net-2.6 PATCH 1/3] be2net: Bug fix to avoid soft lockup in loopback test.
2009-12-24 13:28 ` Jan Ceuleers
@ 2009-12-24 17:42 ` Jan Ceuleers
0 siblings, 0 replies; 4+ messages in thread
From: Jan Ceuleers @ 2009-12-24 17:42 UTC (permalink / raw)
To: Sarveshwar Bandi; +Cc: netdev, davem
Sarveshwar bandi wrote:
> Yes. thats what i meant.
>
> - Sarvesh
OK, thanks for clarifying.
Jan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-12-24 17:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-23 14:40 [net-2.6 PATCH 1/3] be2net: Bug fix to avoid soft lockup in loopback test Sarveshwar Bandi
2009-12-24 4:58 ` David Miller
2009-12-24 13:28 ` Jan Ceuleers
2009-12-24 17:42 ` Jan Ceuleers
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).