netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: Simon Horman <horms@verge.net.au>,
	netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
	Wensong Zhang <wensong@linux-vs.org>,
	Julian Anastasov <ja@ssi.bg>, David Miller <davem@davemloft.net>
Subject: Re: [PATCH] ipvs: Add boundary check on ioctl arguments
Date: Mon, 04 Jan 2010 16:39:03 +0100	[thread overview]
Message-ID: <4B420B97.5000302@trash.net> (raw)
In-Reply-To: <4B420A89.2010907@linux.intel.com>

Arjan van de Ven wrote:
> On 1/4/2010 5:59, Patrick McHardy wrote:
> 
> [sorry for the late response, just got back from a good holiday, which
> means no work email access ;-) ]
> 
>> Simon Horman wrote:
> 
>>> I agree with Julian's assessment that your patch shouldn't be
>>> necessary, but on the other hand I think that the checks are
>>> reasonable. Your original patch made checks of the form of
>>> "cmd>  IP_VS_SO_GET_MAX + 1". I have updated this to
>>> "cmd>  IP_VS_SO_GET_MAX", as suggested by Julian, as the optmax
>>> elements of struct nf_sockopt_ops set a non-inclusive range.
>>>
>>> http://lkml.indiana.edu/hypermail/linux/kernel/0910.0/00852.html
>>>
>>> Index: net-next-2.6/net/netfilter/ipvs/ip_vs_ctl.c
>>
>> As a bugfix, this seems more appropriate for net-2.6.git. Please let
>> me know which tree you want me to apply this to.
> 
> this really ought to go into 2.6.33.....

Thanks, applied and will send it upstream soon.

  reply	other threads:[~2010-01-04 15:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-29  1:58 [PATCH] ipvs: Add boundary check on ioctl arguments Simon Horman
2010-01-04 13:59 ` Patrick McHardy
2010-01-04 15:34   ` Arjan van de Ven
2010-01-04 15:39     ` Patrick McHardy [this message]
2010-01-04 23:25       ` Simon Horman
  -- strict thread matches above, loose matches on Subject: below --
2009-09-30 11:11 Arjan van de Ven
2009-09-30 13:38 ` Hannes Eder
2009-09-30 15:18   ` Arjan van de Ven
2009-09-30 15:33     ` Hannes Eder
2009-09-30 19:41     ` Julian Anastasov
2009-10-01  7:22       ` Arjan van de Ven
2009-10-02  8:35     ` Julian Anastasov
2009-12-15  6:17 ` Arjan van de Ven
2009-12-15  6:32   ` Simon Horman
2009-12-24  4:16     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B420B97.5000302@trash.net \
    --to=kaber@trash.net \
    --cc=arjan@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=horms@verge.net.au \
    --cc=ja@ssi.bg \
    --cc=lvs-devel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=wensong@linux-vs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).