From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH] drivers/net/stmmac/gmac.c: use %pM to show MAC address
Date: Tue, 05 Jan 2010 09:02:46 +0100 [thread overview]
Message-ID: <4B42F226.6010207@st.com> (raw)
In-Reply-To: <BD79186B4FD85F4B8E60E381CAEE19090200F674@mi8nycmail19.Mi8.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Hartley,
H Hartley Sweeten wrote:
> Use the %pM kernel extension to display the MAC address.
Thanks for this patch.
As discussed in the mailing list, I'm reworking some patches for the
stmmac driver (fixing compilation errors and trying to make the code
more generic).
I've already modified the gmac.c file now splitted in new two files.
So I'm wondering if it's worth applying this patch into the new code,
directly.
Regards,
Peppe
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: David S. Miller <davem@davemloft.net>
> ---
>
> diff --git a/drivers/net/stmmac/gmac.c b/drivers/net/stmmac/gmac.c
> index 52586ee..7700772 100644
> --- a/drivers/net/stmmac/gmac.c
> +++ b/drivers/net/stmmac/gmac.c
> @@ -481,12 +481,8 @@ static void gmac_set_filter(struct net_device *dev)
> gmac_set_umac_addr(ioaddr, uc_ptr->da_addr,
> i + 1);
>
> - DBG(KERN_INFO "\t%d "
> - "- Unicast addr %02x:%02x:%02x:%02x:%02x:"
> - "%02x\n", i + 1,
> - uc_ptr->da_addr[0], uc_ptr->da_addr[1],
> - uc_ptr->da_addr[2], uc_ptr->da_addr[3],
> - uc_ptr->da_addr[4], uc_ptr->da_addr[5]);
> + DBG(KERN_INFO "\t%d - Unicast addr %pM\n",
> + i + 1, uc_ptr->da_addr);
> uc_ptr = uc_ptr->next;
> }
> }
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAktC8iAACgkQ2Xo3j31MSSJ+DACguvgHAeRm2Qy+N6Lw8svt/nna
Z0sAnRjHHkG+FYtyu0OfjOrRi8eu9SyN
=srnl
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2010-01-05 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-30 20:20 [PATCH] drivers/net/stmmac/gmac.c: use %pM to show MAC address H Hartley Sweeten
2010-01-05 8:02 ` Giuseppe CAVALLARO [this message]
2010-01-05 15:26 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B42F226.6010207@st.com \
--to=peppe.cavallaro@st.com \
--cc=davem@davemloft.net \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).