From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Neil Horman <nhorman@tuxdriver.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: packet: option to only pass skb protocol
Date: Tue, 05 Jan 2010 20:27:21 +0100 [thread overview]
Message-ID: <4B439299.1090205@gmail.com> (raw)
In-Reply-To: <20100105185732.GA30346@redhat.com>
Le 05/01/2010 19:57, Michael S. Tsirkin a écrit :
> When sending packets with a packet socket it is often necessary to set
> protocol in msg_name: otherwise the protocol field in the skb will not
> be set correctly. However, currently doing this also requires
> supplying the interface index.
>
> The following patch makes it possible to avoid supplying the interface
> index by interpreting index 0 as "use device this socket is bound to".
>
Patch is correct, but I dont understand why zero initialization by caller
is any better then supplying ifindex (known when socket was bound to device ?)
To avoid one syscall at socket setup (to get ifindex from dev name),
you prefer to add a test/branch at each send() syscall...
Am I missing something ?
next prev parent reply other threads:[~2010-01-05 19:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 18:57 [PATCH] net: packet: option to only pass skb protocol Michael S. Tsirkin
2010-01-05 19:27 ` Eric Dumazet [this message]
2010-01-05 20:50 ` Michael S. Tsirkin
2010-01-05 21:40 ` David Miller
2010-01-05 21:50 ` Michael S. Tsirkin
2010-01-05 21:28 ` Chris Friesen
2010-01-05 21:42 ` David Miller
2010-01-05 21:45 ` Michael S. Tsirkin
2010-01-05 22:05 ` Michael S. Tsirkin
2010-01-05 22:13 ` Chris Friesen
2010-01-05 22:27 ` Michael S. Tsirkin
2010-01-05 23:51 ` David Miller
2010-01-06 9:12 ` Michael S. Tsirkin
2010-01-06 19:24 ` Michael S. Tsirkin
2010-01-07 8:27 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B439299.1090205@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).