netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Ceuleers <jan.ceuleers@computer.org>
To: Simon Kagstrom <simon.kagstrom@netinsight.net>
Cc: netdev@vger.kernel.org, "David Miller" <davem@davemloft.net>,
	"Stéphane Berthelot" <sberthelot@emisfr.com>
Subject: Re: [PATCH] via-velocity: add netpoll functionality for the benefit of netconsole
Date: Tue, 05 Jan 2010 21:19:33 +0100	[thread overview]
Message-ID: <4B439ED5.0@computer.org> (raw)
In-Reply-To: <20100105072800.13dba6d2@marrow.netinsight.se>

Simon Kagstrom wrote:
> Does the patch still work with the new NAPI support in the driver?

Errr. (Is my ignorance showing yet?)

I will have to study this, based on other drivers and your commit dfff71.

I would be grateful for any hints, but otherwise will endeavour to figure it out myself.

>> +static void velocity_poll_controller(struct net_device *dev)
>> +{
>> +	disable_irq(dev->irq);
>> +	velocity_intr(dev->irq, dev);
>> +	enable_irq(dev->irq);
>> +}
> 
> This should probably have an
> 
> #ifdef CONFIG_NET_POLL_CONTROLLER
> ...
> #endif
> 
> around it

You are right, will add.


Thanks, Jan

  reply	other threads:[~2010-01-05 20:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-04 18:32 [PATCH] via-velocity: add netpoll functionality for the benefit of netconsole Jan Ceuleers
2010-01-05  6:28 ` Simon Kagstrom
2010-01-05 20:19   ` Jan Ceuleers [this message]
2010-01-07  6:26     ` Simon Kagstrom
2010-01-10  9:06       ` Jan Ceuleers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B439ED5.0@computer.org \
    --to=jan.ceuleers@computer.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=sberthelot@emisfr.com \
    --cc=simon.kagstrom@netinsight.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).