From: Daniel Borkmann <danborkmann@googlemail.com>
To: David Miller <davem@davemloft.net>
Cc: mpm@selenic.com, danborkmann@googlemail.com,
linux-kernel@vger.kernel.org, jmoyer@redhat.com,
netdev@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: [PATCH] netpoll: allow execution of multiple rx_hooks per interface
Date: Thu, 07 Jan 2010 20:06:40 +0100 [thread overview]
Message-ID: <4B4630C0.6090206@gmail.com> (raw)
In-Reply-To: <20100107.010201.51693251.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 897 bytes --]
David Miller wrote:
> From: Matt Mackall <mpm@selenic.com>
> Date: Wed, 06 Jan 2010 21:54:05 -0600
>
>> Please inline patches so they can be reviewed easily in reply.
>>
>>
>> - struct netpoll *np = npi->rx_np;
>> + struct netpoll **np = &npi->rx_np;
>>
>> - if (!np)
>> + if (!(*np))
>>
>> This makes everything horrible. Can you avoid the double indirection?
>> Using a list head might be a good answer.
>>
>
> Agreed on all counts.
>
Agreed on the double indirection, I'll fix it.
I've already considered the list_head structure, but then I was the opinion
that a double linked list might not be necessary for this, so I did it that
way ... (compare: kernel notifier by Alan Cox). If you insist on that I'll
fix it of course ;)
Best regards,
Daniel
P.s.: Sorry Matt for not CCing. I mainly took those addresses from Jeffs post.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]
next prev parent reply other threads:[~2010-01-07 19:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 20:54 [PATCH] netpoll: allow execution of multiple rx_hooks per interface Daniel Borkmann
2010-01-07 3:54 ` Matt Mackall
2010-01-07 9:02 ` David Miller
2010-01-07 19:06 ` Daniel Borkmann [this message]
2010-01-08 0:20 ` Daniel Borkmann
2010-01-11 23:21 ` Matt Mackall
2010-01-11 23:59 ` David Miller
2010-01-12 0:03 ` Matt Mackall
2010-01-12 0:09 ` Daniel Borkmann
2010-01-13 0:27 ` Daniel Borkmann
2010-01-13 13:57 ` Jeff Moyer
2010-01-13 16:53 ` Daniel Borkmann
2010-01-14 4:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4630C0.6090206@gmail.com \
--to=danborkmann@googlemail.com \
--cc=davem@davemloft.net \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@oss.sgi.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).