From: Oliver Hartkopp <socketcan-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>
To: Wolfgang Grandegger <wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
Cc: SocketCAN Core Mailing List
<socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org>,
Linux Netdev List
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Marc Kleine-Budde <mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Subject: Re: [PATCH net-next-2.6 v4] can: Unify droping of invalid tx skbs and netdev stats
Date: Tue, 12 Jan 2010 10:25:51 +0100 [thread overview]
Message-ID: <4B4C401F.9010703@hartkopp.net> (raw)
In-Reply-To: <4B4C3FA0.7000403-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
Wolfgang Grandegger wrote:
> Oliver,
>
> Oliver Hartkopp wrote:
>> To prevent the CAN drivers to operate on invalid socketbuffers the skbs are
>> now checked and silently dropped at the xmit-function consistently.
>>
>> Also the netdev stats are consistently using the CAN data length code (dlc)
>> for [rx|tx]_bytes now.
>>
>> Signed-off-by: Oliver Hartkopp <oliver-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>
>
> I just realized, mscan/mscan.c should then also use that helper function.
>
> Wolfgang.
Will send a v5 ;-)
Oliver
prev parent reply other threads:[~2010-01-12 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 8:50 [PATCH net-next-2.6 v4] can: Unify droping of invalid tx skbs and netdev stats Oliver Hartkopp
[not found] ` <4B4C37CB.4000706-fJ+pQTUTwRTk1uMJSBkQmQ@public.gmane.org>
2010-01-12 9:23 ` Wolfgang Grandegger
[not found] ` <4B4C3FA0.7000403-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-01-12 9:25 ` Oliver Hartkopp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4C401F.9010703@hartkopp.net \
--to=socketcan-fj+pqtutwrtk1umjsbkqmq@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
--cc=wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).