From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Hartkopp Subject: Re: [PATCH net-next-2.6 v4] can: Unify droping of invalid tx skbs and netdev stats Date: Tue, 12 Jan 2010 10:25:51 +0100 Message-ID: <4B4C401F.9010703@hartkopp.net> References: <4B4C37CB.4000706@hartkopp.net> <4B4C3FA0.7000403@grandegger.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: SocketCAN Core Mailing List , Linux Netdev List , Marc Kleine-Budde , David Miller To: Wolfgang Grandegger Return-path: In-Reply-To: <4B4C3FA0.7000403-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org Wolfgang Grandegger wrote: > Oliver, > > Oliver Hartkopp wrote: >> To prevent the CAN drivers to operate on invalid socketbuffers the skbs are >> now checked and silently dropped at the xmit-function consistently. >> >> Also the netdev stats are consistently using the CAN data length code (dlc) >> for [rx|tx]_bytes now. >> >> Signed-off-by: Oliver Hartkopp > > I just realized, mscan/mscan.c should then also use that helper function. > > Wolfgang. Will send a v5 ;-) Oliver