From: Jiri Slaby <jirislaby@gmail.com>
To: ron.mercer@qlogic.com
Cc: linux-driver@qlogic.com, netdev@vger.kernel.org
Subject: qla3xxx: sleep in atomic
Date: Wed, 13 Jan 2010 13:23:41 +0100 [thread overview]
Message-ID: <4B4DBB4D.9070807@gmail.com> (raw)
Hi,
stanse found a potential sleep inside atomic context. ql_sem_spinlock
must be called with hw_lock which is spinlock (locked with irq disabled
btw.), but ql_sem_spinlock calls ssleep when the HW spinlock cannot be
taken. Could you fix that somehow. E.g. unlock; sleep; lock; if not
called from irq context at all. Or alternatively lower the sleep
interval to usecs and use udelay as it seems it never trigerred (the hw
lock never failed), because people would get deadlocks otherwise.
regards,
--
js
next reply other threads:[~2010-01-13 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 12:23 Jiri Slaby [this message]
2010-01-13 12:27 ` qla3xxx: sleep in atomic Jiri Slaby
2010-01-13 12:31 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4DBB4D.9070807@gmail.com \
--to=jirislaby@gmail.com \
--cc=linux-driver@qlogic.com \
--cc=netdev@vger.kernel.org \
--cc=ron.mercer@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).