* qla3xxx: sleep in atomic
@ 2010-01-13 12:23 Jiri Slaby
2010-01-13 12:27 ` Jiri Slaby
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Slaby @ 2010-01-13 12:23 UTC (permalink / raw)
To: ron.mercer; +Cc: linux-driver, netdev
Hi,
stanse found a potential sleep inside atomic context. ql_sem_spinlock
must be called with hw_lock which is spinlock (locked with irq disabled
btw.), but ql_sem_spinlock calls ssleep when the HW spinlock cannot be
taken. Could you fix that somehow. E.g. unlock; sleep; lock; if not
called from irq context at all. Or alternatively lower the sleep
interval to usecs and use udelay as it seems it never trigerred (the hw
lock never failed), because people would get deadlocks otherwise.
regards,
--
js
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: qla3xxx: sleep in atomic
2010-01-13 12:23 qla3xxx: sleep in atomic Jiri Slaby
@ 2010-01-13 12:27 ` Jiri Slaby
2010-01-13 12:31 ` Jiri Slaby
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Slaby @ 2010-01-13 12:27 UTC (permalink / raw)
To: ron.mercer; +Cc: linux-driver, netdev
On 01/13/2010 01:23 PM, Jiri Slaby wrote:
> stanse found a potential sleep inside atomic context. ql_sem_spinlock
> must be called with hw_lock which is spinlock (locked with irq disabled
I've sent it too early. I overlooked another report before. The same
holds for ql_wait_for_drvr_lock.
--
js
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: qla3xxx: sleep in atomic
2010-01-13 12:27 ` Jiri Slaby
@ 2010-01-13 12:31 ` Jiri Slaby
0 siblings, 0 replies; 3+ messages in thread
From: Jiri Slaby @ 2010-01-13 12:31 UTC (permalink / raw)
To: ron.mercer; +Cc: linux-driver, netdev
On 01/13/2010 01:27 PM, Jiri Slaby wrote:
> On 01/13/2010 01:23 PM, Jiri Slaby wrote:
>> stanse found a potential sleep inside atomic context. ql_sem_spinlock
>> must be called with hw_lock which is spinlock (locked with irq disabled
>
> I've sent it too early. I overlooked another report before. The same
> holds for ql_wait_for_drvr_lock.
Fuck, and for ql_adapter_reset from both qla3xxx and qlge plus
ql_sem_trylock from the latter.
--
js
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-13 12:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-13 12:23 qla3xxx: sleep in atomic Jiri Slaby
2010-01-13 12:27 ` Jiri Slaby
2010-01-13 12:31 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).