From: John Fastabend <john.r.fastabend@intel.com>
To: David Miller <davem@davemloft.net>
Cc: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"gospo@redhat.com" <gospo@redhat.com>
Subject: Re: [net-next-2.6 PATCH] ixgbe: only process one ixgbe_watchdog_task at a time.
Date: Sun, 24 Jan 2010 22:24:18 -0800 [thread overview]
Message-ID: <4B5D3912.9030802@intel.com> (raw)
In-Reply-To: <20100123.021941.134608202.davem@davemloft.net>
David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Sat, 23 Jan 2010 02:17:31 -0800
>
>
>> diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
>> index 8d206f7..cbc62db 100644
>> --- a/drivers/net/ixgbe/ixgbe_main.c
>> +++ b/drivers/net/ixgbe/ixgbe_main.c
>> @@ -5013,7 +5013,8 @@ static void ixgbe_watchdog_task(struct work_struct *work)
>> struct ixgbe_ring *tx_ring;
>> int some_tx_pending = 0;
>>
>> - adapter->flags |= IXGBE_FLAG_IN_WATCHDOG_TASK;
>> + while (test_and_set_bit(__IXGBE_IN_WATCHDOG_TASK, &adapter->state))
>> + msleep(1);
>>
>>
>
> I think using a mutex() would better serve you here.
>
I'll make this change and resubmit. Thanks.
prev parent reply other threads:[~2010-01-25 6:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-23 10:17 [net-next-2.6 PATCH] ixgbe: only process one ixgbe_watchdog_task at a time Jeff Kirsher
2010-01-23 10:19 ` David Miller
2010-01-25 6:24 ` John Fastabend [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5D3912.9030802@intel.com \
--to=john.r.fastabend@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).