From: Kristoffer Glembo <kristoffer@gaisler.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/1 V3] net: Add Aeroflex Gaisler 10/100/1G Ethernet MAC driver
Date: Mon, 25 Jan 2010 11:54:55 +0100 [thread overview]
Message-ID: <4B5D787F.2040003@gaisler.com> (raw)
In-Reply-To: <20100123.020549.147260506.davem@davemloft.net>
David Miller wrote:
>
> Generates build warnings, please fix:
>
> drivers/net/greth.c: In function ‘greth_rx’:
> drivers/net/greth.c:781: warning: passing argument 1 of ‘greth_print_rx_packet’ makes integer from pointer without a cast
> drivers/net/greth.c: In function ‘greth_rx_gbit’:
> drivers/net/greth.c:885: warning: passing argument 1 of ‘greth_print_rx_packet’ makes integer from pointer without a cast
>
> phys_to_virt() give a virtual address pointer, so this should
> have generated warnings on 64-bit as well as 32-bit systems.
>
> I can't see how you could have possibly build tested this and
> not seen the warnings.
After removing the #defines that guarded those calls I only built it as part of the
whole kernel and forgot to check for any warnings. Sorry!
I'll resend ...
/Kristoffer
prev parent reply other threads:[~2010-01-25 10:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 12:51 [PATCH 0/1 V3] net: Add Aeroflex Gaisler 10/100/1G Ethernet MAC driver Kristoffer Glembo
2010-01-22 12:51 ` [PATCH 1/1 " Kristoffer Glembo
2010-01-23 10:05 ` David Miller
2010-01-25 10:54 ` Kristoffer Glembo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5D787F.2040003@gaisler.com \
--to=kristoffer@gaisler.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).