From: Jens Rottmann <JRottmann@LiPPERTEmbedded.de>
To: Tristram Ha <Tristram.Ha@Micrel.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.33 1/3] net: Micrel KSZ8841/2 PCI Ethernet driver
Date: Mon, 25 Jan 2010 19:14:08 +0100 [thread overview]
Message-ID: <4B5DDF70.8010709@LiPPERTEmbedded.de> (raw)
In ksz884x.c: read_other_addr(struct ksz_hw *hw)
"u16 data[3]" instead of "u16 data[4]" is sufficient.
And when checking if the 2nd MAC is actually stored in EEPROM or if it's only
all empty (only FF) you overlooked that you're doing it wordwise, so you'll
have to check "data[0] != 0xffff" instead of "data[0] != 0xff".
Best regards,
Jens Rottmann
next reply other threads:[~2010-01-25 18:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 18:14 Jens Rottmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-02-08 21:36 [PATCH 2.6.33 1/3] net: Micrel KSZ8841/2 PCI Ethernet driver Ha, Tristram
2010-01-16 2:57 Ha, Tristram
2010-01-16 9:20 ` David Miller
2010-01-19 20:03 ` Ha, Tristram
2010-01-19 21:40 ` Stephen Hemminger
2010-01-19 23:48 ` Ha, Tristram
2010-01-20 0:11 ` Stephen Hemminger
2010-01-20 0:34 ` Ha, Tristram
2010-01-20 0:50 ` Stephen Hemminger
2010-01-16 14:50 ` Alan Cox
2010-01-19 21:22 ` Ha, Tristram
2010-01-19 21:32 ` Alan Cox
2010-01-20 0:12 ` Ha, Tristram
2010-01-16 16:00 ` Michał Mirosław
2010-01-16 16:16 ` Felix Fietkau
2010-01-19 21:51 ` Ha, Tristram
2010-01-19 22:11 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5DDF70.8010709@LiPPERTEmbedded.de \
--to=jrottmann@lippertembedded.de \
--cc=Tristram.Ha@Micrel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).