netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kristoffer Glembo <kristoffer@gaisler.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH 1/1 V4] net: Add Aeroflex Gaisler 10/100/1G Ethernet MAC driver
Date: Wed, 27 Jan 2010 12:01:45 +0100	[thread overview]
Message-ID: <4B601D19.9050908@gaisler.com> (raw)
In-Reply-To: <20100125083131.568abc34@nehalam>

Hi,

Stephen Hemminger wrote:
> On Mon, 25 Jan 2010 12:01:12 +0100
> Kristoffer Glembo <kristoffer@gaisler.com> wrote:
> 
>> +/* Accept MAC address of the form macaddr=0x08,0x00,0x20,0x30,0x40,0x50 */
>> +static int macaddr[6];
>> +module_param_array(macaddr, int, NULL, 0);
>> +MODULE_PARM_DESC(macaddr, "GRETH Ethernet MAC address");
> 
> Don't you want an array of uchar here not int?
> 

I copied this approach from the sunhme driver and it works fine. Any special
reason to change it?

I have incorporated the rest of your feedback including ethtool support. 

Thanks a lot for the review!

Best regards,
Kristoffer Glembo

  reply	other threads:[~2010-01-27 11:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-25 11:01 [PATCH 0/1 V4] net: Add Aeroflex Gaisler 10/100/1G Ethernet MAC driver Kristoffer Glembo
2010-01-25 11:01 ` [PATCH 1/1 " Kristoffer Glembo
2010-01-25 16:31   ` Stephen Hemminger
2010-01-27 11:01     ` Kristoffer Glembo [this message]
2010-01-25 16:33   ` Stephen Hemminger
2010-01-25 16:36   ` Stephen Hemminger
2010-01-25 16:37   ` Stephen Hemminger
2010-01-25 16:39   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B601D19.9050908@gaisler.com \
    --to=kristoffer@gaisler.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).