From: Cong Wang <amwang@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
David Miller <davem@davemloft.net>
Subject: Re: [Patch] net: export TCP send buffer size via netlink
Date: Mon, 01 Feb 2010 17:04:33 +0800 [thread overview]
Message-ID: <4B669921.6090808@redhat.com> (raw)
In-Reply-To: <1265014309.2848.7.camel@edumazet-laptop>
Eric Dumazet wrote:
> Le lundi 01 février 2010 à 02:59 -0500, Amerigo Wang a écrit :
>> Currently, we can only get TCP send buffer size by
>> getsockopt (SO_SNDBUF or TCP_INFO), this is not enough
>> for the tools like netstat or ss to read.
>>
>> Show TCP send buffer size via netlink NETLINK_INET_DIAG.
>>
>> Signed-off-by: WANG Cong <amwang@redhat.com>
>> Cc: David Miller <davem@davemloft.net>
>>
>> ---
>> diff --git a/include/linux/tcp.h b/include/linux/tcp.h
>> index 7fee8a4..46768de 100644
>> --- a/include/linux/tcp.h
>> +++ b/include/linux/tcp.h
>> @@ -136,6 +136,7 @@ struct tcp_info {
>> __u32 tcpi_ato;
>> __u32 tcpi_snd_mss;
>> __u32 tcpi_rcv_mss;
>> + __u32 tcpi_sndbuf;
>>
>> __u32 tcpi_unacked;
>> __u32 tcpi_sacked;
>
> You cannot change tcp_info like this, this structure is used by some
> programs, and they are going to break badly.
>
Oh, right, I forgot the ABI compatibility...
I will append it to this structure.
Thanks!
next prev parent reply other threads:[~2010-02-01 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 7:59 [Patch] net: export TCP send buffer size via netlink Amerigo Wang
2010-02-01 8:51 ` Eric Dumazet
2010-02-01 9:04 ` Cong Wang [this message]
2010-02-01 9:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B669921.6090808@redhat.com \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).