From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [net-next-2.6 PATCH v2 1/3] ethtool: Introduce n-tuple filter programming support Date: Thu, 04 Feb 2010 17:55:51 -0500 Message-ID: <4B6B5077.9070005@garzik.org> References: <20100204074811.16559.84676.stgit@localhost.localdomain> <20100204.091854.24215476.davem@davemloft.net> <4B6B4B87.6020500@garzik.org> <1265323938.2780.6.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: David Miller , "Kirsher, Jeffrey T" , "netdev@vger.kernel.org" , "gospo@redhat.com" To: Peter P Waskiewicz Jr Return-path: Received: from mail-yx0-f204.google.com ([209.85.210.204]:52497 "EHLO mail-yx0-f204.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757590Ab0BDWzy (ORCPT ); Thu, 4 Feb 2010 17:55:54 -0500 Received: by yxe42 with SMTP id 42so2576877yxe.22 for ; Thu, 04 Feb 2010 14:55:53 -0800 (PST) In-Reply-To: <1265323938.2780.6.camel@localhost> Sender: netdev-owner@vger.kernel.org List-ID: On 02/04/2010 05:52 PM, Peter P Waskiewicz Jr wrote: > On Thu, 2010-02-04 at 14:34 -0800, Jeff Garzik wrote: >> On 02/04/2010 04:26 PM, Waskiewicz Jr, Peter P wrote: >>> On Thu, 4 Feb 2010, David Miller wrote: >>> >>>> From: Jeff Kirsher >>>> Date: Wed, 03 Feb 2010 23:48:13 -0800 >>>> >>>>> +#define ETHTOOL_RXNTUPLE_ACTION_DROP -1 >>>>> + struct list_head list; >>>>> +}; >>>> >>>> You can't do this. >>>> >>>> You put the list_head here in the kernel header, which BTW can >>>> be used by userspace too, and then you elide it in the >>>> ethtool utility copy of the header. >>>> >>>> Use an encapsulator if you must inside of the kernel, but keep the >>>> userspace visible data structure clean of RCU and list_head >>>> kernel datastructures. >>> >>> Ok. I'll respin this asap. Thanks for the quick review Dave. >> >> Great. I'll look for the updated userspace patch, too, and put it into >> the ethtool-2.6.34 pile (ie. ethtool-net-next). >> > > I didn't plan on respinning the userspace side. I put a container > wrapped around the flow_spec struct to do the list management in the > kernel. This shouldn't need a change to userspace. Well, I figured there would be some trivial tweaks and patch offsets, because we want to keep the kernel ethtool.h and userspace ethtool-copy.h headers in sync. Either way, no big deal. I'll make sure net-next and ethtool match up, after your userspace patch is applied, one way or the other. Jeff