From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulius Zaleckas Subject: Re: [PATCH] obsolete config in kernel source (HSO_AUTOPM) Date: Fri, 05 Feb 2010 16:37:01 +0200 Message-ID: <4B6C2D0D.6020608@gmail.com> References: <20100205133918.GA7077__48535.5327524759$1265377184$gmane$org@faui49.informatik.uni-erlangen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jan Dumon , Greg Kroah-Hartman , "David S. Miller" , Stephen Hemminger , "Paulius Zaleckas"@ger.gmane.org To: netdev@vger.kernel.org Return-path: Received: from lo.gmane.org ([80.91.229.12]:41218 "EHLO lo.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751369Ab0BFOkL (ORCPT ); Sat, 6 Feb 2010 09:40:11 -0500 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1NdlpN-00018z-Dg for netdev@vger.kernel.org; Sat, 06 Feb 2010 15:40:05 +0100 Received: from 89.249.92.238 ([89.249.92.238]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 06 Feb 2010 15:40:05 +0100 Received: from paulius.zaleckas by 89.249.92.238 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 06 Feb 2010 15:40:05 +0100 In-Reply-To: <20100205133918.GA7077__48535.5327524759$1265377184$gmane$org@faui49.informatik.uni-erlangen.de> Sender: netdev-owner@vger.kernel.org List-ID: On 02/05/2010 03:39 PM, Christoph Egger wrote: > Hi all! > > As part of the VAMOS[0] research project at the University of > Erlangen we're checking referential integrity between kernel KConfig > options and in-code Conditional blocks. > > This is just a one-liner commented out unconditionally (due to > the config not existing) and being like this for virtually ever so I'm > suggesting to remove it from the kernel tree. > > Please keep me informed of this patch getting confirmed / > merged so we can keep track of it. > > Regards > > Christoph Egger > > [0] http://vamos1.informatik.uni-erlangen.de/ > > ---- > From 4d76c063b34cffd7b0f175e328f0878f262e6af2 Mon Sep 17 00:00:00 2001 > From: Christoph Egger > Date: Fri, 5 Feb 2010 13:46:21 +0100 > Subject: [PATCH] Remove unreferenced HSO_AUTOPM > > CONFIG_HSO_AUTOPM is set by KConfig / set in the Kernel source, > makefiles and won't be ever set this way, therefor simply removing the > protected code. > > Signed-off-by: Christoph Egger > --- > drivers/net/usb/hso.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c > index 6895f15..be0cc99 100644 > --- a/drivers/net/usb/hso.c > +++ b/drivers/net/usb/hso.c > @@ -1155,9 +1155,6 @@ static void _hso_serial_set_termios(struct tty_struct *tty, > static void hso_resubmit_rx_bulk_urb(struct hso_serial *serial, struct urb *urb) > { > int result; > -#ifdef CONFIG_HSO_AUTOPM > - usb_mark_last_busy(urb->dev); > -#endif Acctually this is bug. usb_mark_last_busy() should be called here. Can you resend this patch by just removing #ifdef and #endif and leaving usb_mark_last_busy()? > /* We are done with this URB, resubmit it. Prep the USB to wait for > * another frame */ > usb_fill_bulk_urb(urb, serial->parent->usb,