From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: netdev <netdev@vger.kernel.org>
Subject: bnx2 limits user-specified advertised speeds to one
Date: Wed, 10 Feb 2010 16:05:14 -0500 [thread overview]
Message-ID: <4B731F8A.20508@hp.com> (raw)
Hi
A customer has noted that when attempting to change the advertised speeds
setting on card using a bnx2 driver, the driver advertises either all available
speeds or just one. In other words, if a user attempts to set multiple
advertised speeds, the settings will not be honored.
Looking at the code in bnx2_set_settings, the checks for 10baseT and 100baseT
make an assumption that the user provided only 1 speed setting.
e1000 and e1000e work correctly when the user specifies multiple advertised
speeds.
Before attempting to fix this, I wanted to ask if there was a reason for the
current functionality.
Thanks
-vlad
next reply other threads:[~2010-02-10 21:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-10 21:05 Vlad Yasevich [this message]
2010-02-10 22:11 ` bnx2 limits user-specified advertised speeds to one Michael Chan
2010-02-10 23:35 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B731F8A.20508@hp.com \
--to=vladislav.yasevich@hp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).