From: Sridhar Samudrala <sri@us.ibm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: David Miller <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next-2.6] macvtap: Add GSO/csum offload support
Date: Mon, 15 Feb 2010 09:05:42 -0800 [thread overview]
Message-ID: <4B797EE6.8070203@us.ibm.com> (raw)
In-Reply-To: <201002142013.08745.arnd@arndb.de>
On 2/14/2010 11:13 AM, Arnd Bergmann wrote:
> On Saturday 13 February 2010 21:55:37 Sridhar Samudrala wrote:
>
>>> Also, what about IFF_TAP and IFF_NO_PI, should those be always set?
>>>
>>>
>> Atleast it is not required for qemu to have these flags set. If we are
>> not doing anything different based on
>> these flags, i felt we don't need to have them.
>>
> The point is that other applications might depend on them. We only support
> IFF_TAP operation (not IFF_TUN), and we do not understand the !IFF_NO_PI
> frame format, so any program that tries to use the PI header or use cooked
> IP packets will get incorrect data.
>
>
OK. that is a good point. We should handle cases where a user is trying
to set IFF_TUN and !IFF_NO_PI.
Thanks
Sridhar
next prev parent reply other threads:[~2010-02-15 17:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 22:27 [PATCH net-next-2.6] macvtap: Add GSO/csum offload support Sridhar Samudrala
2010-02-13 6:58 ` Sridhar Samudrala
2010-02-13 17:34 ` Arnd Bergmann
2010-02-13 20:55 ` Sridhar Samudrala
2010-02-14 19:13 ` Arnd Bergmann
2010-02-15 0:21 ` Herbert Xu
2010-02-15 9:19 ` Arnd Bergmann
2010-02-15 17:05 ` Sridhar Samudrala [this message]
2010-02-18 16:10 ` Arnd Bergmann
2010-02-18 20:03 ` Sridhar Samudrala
2010-02-18 20:47 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B797EE6.8070203@us.ibm.com \
--to=sri@us.ibm.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).