From: Cong Wang <amwang@redhat.com>
To: Octavian Purdila <opurdila@ixiacom.com>
Cc: David Miller <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Linux Kernel Developers <linux-kernel@vger.kernel.org>,
Neil Horman <nhorman@tuxdriver.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [net-next PATCH v5 3/3] net: reserve ports for applications using fixed port numbers
Date: Sun, 21 Feb 2010 10:00:26 +0800 [thread overview]
Message-ID: <4B8093BA.7010809@redhat.com> (raw)
In-Reply-To: <201002201527.37643.opurdila@ixiacom.com>
Octavian Purdila wrote:
> On Saturday 20 February 2010 10:20:53 you wrote:
>
>>> +unsigned long *sysctl_local_reserved_ports;
>>> +EXPORT_SYMBOL(sysctl_local_reserved_ports);
>>> +
>> Sorry, this looks somewhat weird, why not just export
>> inet_is_reserved_local_port()?
>>
>
> My understanding is that if we do that than we won't be able to inline
> inet_is_reserved_local_port(). And as David said previously that will have a
> significant impact on performance.
Oh, that would be true probably, so just leave as it is.
Thanks.
next prev parent reply other threads:[~2010-02-21 1:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 22:30 [net-next PATCH v5 0/3] net: reserve ports for applications using fixed port numbers Octavian Purdila
2010-02-18 22:30 ` [net-next PATCH v5 1/3] sysctl: refactor integer handling proc code Octavian Purdila
2010-02-18 22:30 ` [net-next PATCH v5 3/3] net: reserve ports for applications using fixed port numbers Octavian Purdila
2010-02-20 8:20 ` Cong Wang
2010-02-20 13:27 ` Octavian Purdila
2010-02-21 2:00 ` Cong Wang [this message]
2010-02-21 6:38 ` Cong Wang
2010-02-20 8:11 ` [net-next PATCH v5 0/3] " Cong Wang
2010-02-20 13:57 ` Octavian Purdila
2010-02-21 1:58 ` Cong Wang
2010-02-21 6:10 ` Bill Fink
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8093BA.7010809@redhat.com \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=opurdila@ixiacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).