From: Cong Wang <amwang@redhat.com>
To: opurdila@ixiacom.com
Cc: David Miller <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Linux Kernel Developers <linux-kernel@vger.kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [net-next PATCH v5 2/3] sysctl: add proc_do_large_bitmap
Date: Mon, 22 Feb 2010 10:45:44 +0800 [thread overview]
Message-ID: <4B81EFD8.8020202@redhat.com> (raw)
In-Reply-To: <1266752533.3428.28.camel@Nokia-N900-42-11>
Octavian Purdila wrote:
>
> But I think its worth to keep the whitespaces in beetween, e.g. allow
>
> $ echo '1, 2 ,3 ' > ip_local_reserved_ports.
Sure.
>
>> Also, if I write an invalid value, it does reject this, but the previous
>> value in that file is cleared, shouldn't we keep the previous one?
>>
>>
>
> The only way I see to fix this is to return EINVAL if we detect a write with offset.
Yeah, we shouldn't continue once we find any invalid value.
>
> IMO we should do that for the other proc write routines as well, as otherwise ther result is confusing, e.g.
>
> write("1 2"); write(" 3");
>
> will set first value in the vector to 1, than second value to 2 then *first* value to 3.
>
> I am all for it, but again, this changes userspace ABI.
Sorry, is this related with the problem I mentioned above? Both "1 2"
and " 3" are valid values.
Thanks.
next prev parent reply other threads:[~2010-02-22 2:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-21 11:42 [net-next PATCH v5 2/3] sysctl: add proc_do_large_bitmap Octavian Purdila
2010-02-22 2:45 ` Cong Wang [this message]
2010-02-22 16:29 ` Octavian Purdila
2010-02-24 5:24 ` Cong Wang
2010-02-24 5:34 ` Cong Wang
2010-02-24 12:02 ` Octavian Purdila
2010-02-25 1:17 ` Cong Wang
2010-02-25 3:18 ` Cong Wang
-- strict thread matches above, loose matches on Subject: below --
2010-02-25 11:02 Octavian Purdila
2010-02-26 2:26 ` Cong Wang
2010-02-25 9:46 Octavian Purdila
2010-02-25 9:54 ` Cong Wang
2010-02-18 22:32 Octavian Purdila
2010-02-21 6:35 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B81EFD8.8020202@redhat.com \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opurdila@ixiacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).