From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Wang Subject: Re: [net-next PATCH v5 2/3] sysctl: add proc_do_large_bitmap Date: Thu, 25 Feb 2010 17:54:07 +0800 Message-ID: <4B8648BF.5070606@redhat.com> References: <1267091195.12391.2.camel@Nokia-N900-42-11> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: David Miller , Linux Kernel Network Developers , Linux Kernel Developers , "Eric W. Biederman" To: opurdila@ixiacom.com Return-path: In-Reply-To: <1267091195.12391.2.camel@Nokia-N900-42-11> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Octavian Purdila wrote: >> Hi, >> >> Still a small problem, if I do write(fd, "50000,50100", 12) I will >> get a return value of 11, which should mean 11 bytes are written, >> however, actually only the first 6 bytes are accepted. >> >> The rest looks better now. >> >> Or am I missing something here? :) >> > > Will take a look at this a bit later today, thanks for testing. > > In the meanwhile what are your thougths on the "1 2 3" issue, are you OK with accepting spaces as well as commas as separators? I think one of them is enough, since we already chose commas, why do we need to add spaces? If you have some strong reason to add it, I have no objections. Thanks.