From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: bonding: fix device leak on error in bond_create() Date: Fri, 26 Feb 2010 17:17:40 +0100 Message-ID: <4B87F424.6090300@trash.net> References: <4B87EA58.7090601@trash.net> <20100226160544.GA2108@gospo.rdu.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Linux Netdev List , Jay Vosburgh To: Andy Gospodarek Return-path: Received: from stinky.trash.net ([213.144.137.162]:59022 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965245Ab0BZQRo (ORCPT ); Fri, 26 Feb 2010 11:17:44 -0500 In-Reply-To: <20100226160544.GA2108@gospo.rdu.redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: Andy Gospodarek wrote: > On Fri, Feb 26, 2010 at 04:35:52PM +0100, Patrick McHardy wrote: > >> commit f357a5caa0ca29b74811a0fc08efb5ae4aade959 >> Author: Patrick McHardy >> Date: Thu Feb 25 20:21:10 2010 +0100 >> >> bonding: fix device leak on error in bond_create() >> >> When the register_netdevice() call fails, the newly allocated device is >> not freed. >> >> Signed-off-by: Patrick McHardy >> >> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c >> index 1787e3c..430c022 100644 >> --- a/drivers/net/bonding/bond_main.c >> +++ b/drivers/net/bonding/bond_main.c >> @@ -4946,6 +4946,8 @@ int bond_create(struct net *net, const char *name) >> } >> >> res = register_netdevice(bond_dev); >> + if (res < 0) >> + goto out_netdev; >> >> out: >> rtnl_unlock(); > > Acked-by: Andy Gospodarek > > Seems like a good idea. I know register_netdevice is always supposed to > return a value < 0 on error, but this would work if it didn't for some > reason. I don't care much, but that would be a bug since we'd return invalid errno codes to userspace.