From: Randy Dunlap <randy.dunlap@oracle.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: David Miller <davem@davemloft.net>,
sfr@canb.auug.org.au, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, shemminger@linux-foundation.org,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [PATCH -next] bridge: depends on INET
Date: Wed, 03 Mar 2010 20:00:22 -0800 [thread overview]
Message-ID: <4B8F3056.1010109@oracle.com> (raw)
In-Reply-To: <20100304031847.GA22683@elte.hu>
On 03/03/10 19:18, Ingo Molnar wrote:
>
> * David Miller <davem@davemloft.net> wrote:
>
>> From: Randy Dunlap <rdunlap@xenotime.net>
>> Date: Tue, 02 Mar 2010 09:08:23 -0800
>>
>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>
>>> br_multicast calls ip_send_check(), so it should depend on INET.
>>>
>>> built-in:
>>> br_multicast.c:(.text+0x88cf4): undefined reference to `ip_send_check'
>>>
>>> or modular:
>>> ERROR: "ip_send_check" [net/bridge/bridge.ko] undefined!
>>>
>>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> Applied, but I almost lost this patch.
>>
>> You need to CC: netdev on all networking patches so that it
>> gets properly tracked in patchwork and therefore does not get
>> lost.
>
> I suspect Randy went by the MAINTAINERS entry - you might want to add netdev
> as a second 'L:' line:
>
> ETHERNET BRIDGE
> M: Stephen Hemminger <shemminger@linux-foundation.org>
> L: bridge@lists.linux-foundation.org
> W: http://www.linux-foundation.org/en/Net:Bridge
> S: Maintained
> F: include/linux/netfilter_bridge/
> F: net/bridge/
>
> To make it really clear that netdev must be Cc:-ed for those patches.
Ack that. I also expected Stephen to merge it...
--
~Randy
next prev parent reply other threads:[~2010-03-04 4:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100302180915.1388d3f3.sfr@canb.auug.org.au>
[not found] ` <4B8D4607.8070603@xenotime.net>
2010-03-03 9:23 ` [PATCH -next] bridge: depends on INET David Miller
2010-03-04 3:18 ` Ingo Molnar
2010-03-04 4:00 ` Randy Dunlap [this message]
2010-03-04 8:42 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B8F3056.1010109@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).