* Re: [PATCH -next] bridge: depends on INET [not found] ` <4B8D4607.8070603@xenotime.net> @ 2010-03-03 9:23 ` David Miller 2010-03-04 3:18 ` Ingo Molnar 0 siblings, 1 reply; 4+ messages in thread From: David Miller @ 2010-03-03 9:23 UTC (permalink / raw) To: rdunlap; +Cc: sfr, linux-next, linux-kernel, shemminger, bridge, netdev From: Randy Dunlap <rdunlap@xenotime.net> Date: Tue, 02 Mar 2010 09:08:23 -0800 > From: Randy Dunlap <randy.dunlap@oracle.com> > > br_multicast calls ip_send_check(), so it should depend on INET. > > built-in: > br_multicast.c:(.text+0x88cf4): undefined reference to `ip_send_check' > > or modular: > ERROR: "ip_send_check" [net/bridge/bridge.ko] undefined! > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Applied, but I almost lost this patch. You need to CC: netdev on all networking patches so that it gets properly tracked in patchwork and therefore does not get lost. Thanks. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] bridge: depends on INET 2010-03-03 9:23 ` [PATCH -next] bridge: depends on INET David Miller @ 2010-03-04 3:18 ` Ingo Molnar 2010-03-04 4:00 ` Randy Dunlap 2010-03-04 8:42 ` David Miller 0 siblings, 2 replies; 4+ messages in thread From: Ingo Molnar @ 2010-03-04 3:18 UTC (permalink / raw) To: David Miller Cc: rdunlap, sfr, linux-next, linux-kernel, shemminger, bridge, netdev * David Miller <davem@davemloft.net> wrote: > From: Randy Dunlap <rdunlap@xenotime.net> > Date: Tue, 02 Mar 2010 09:08:23 -0800 > > > From: Randy Dunlap <randy.dunlap@oracle.com> > > > > br_multicast calls ip_send_check(), so it should depend on INET. > > > > built-in: > > br_multicast.c:(.text+0x88cf4): undefined reference to `ip_send_check' > > > > or modular: > > ERROR: "ip_send_check" [net/bridge/bridge.ko] undefined! > > > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> > > Applied, but I almost lost this patch. > > You need to CC: netdev on all networking patches so that it > gets properly tracked in patchwork and therefore does not get > lost. I suspect Randy went by the MAINTAINERS entry - you might want to add netdev as a second 'L:' line: ETHERNET BRIDGE M: Stephen Hemminger <shemminger@linux-foundation.org> L: bridge@lists.linux-foundation.org W: http://www.linux-foundation.org/en/Net:Bridge S: Maintained F: include/linux/netfilter_bridge/ F: net/bridge/ To make it really clear that netdev must be Cc:-ed for those patches. Thanks, Ingo ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] bridge: depends on INET 2010-03-04 3:18 ` Ingo Molnar @ 2010-03-04 4:00 ` Randy Dunlap 2010-03-04 8:42 ` David Miller 1 sibling, 0 replies; 4+ messages in thread From: Randy Dunlap @ 2010-03-04 4:00 UTC (permalink / raw) To: Ingo Molnar Cc: David Miller, sfr, linux-next, linux-kernel, shemminger, bridge, netdev On 03/03/10 19:18, Ingo Molnar wrote: > > * David Miller <davem@davemloft.net> wrote: > >> From: Randy Dunlap <rdunlap@xenotime.net> >> Date: Tue, 02 Mar 2010 09:08:23 -0800 >> >>> From: Randy Dunlap <randy.dunlap@oracle.com> >>> >>> br_multicast calls ip_send_check(), so it should depend on INET. >>> >>> built-in: >>> br_multicast.c:(.text+0x88cf4): undefined reference to `ip_send_check' >>> >>> or modular: >>> ERROR: "ip_send_check" [net/bridge/bridge.ko] undefined! >>> >>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> >> >> Applied, but I almost lost this patch. >> >> You need to CC: netdev on all networking patches so that it >> gets properly tracked in patchwork and therefore does not get >> lost. > > I suspect Randy went by the MAINTAINERS entry - you might want to add netdev > as a second 'L:' line: > > ETHERNET BRIDGE > M: Stephen Hemminger <shemminger@linux-foundation.org> > L: bridge@lists.linux-foundation.org > W: http://www.linux-foundation.org/en/Net:Bridge > S: Maintained > F: include/linux/netfilter_bridge/ > F: net/bridge/ > > To make it really clear that netdev must be Cc:-ed for those patches. Ack that. I also expected Stephen to merge it... -- ~Randy ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] bridge: depends on INET 2010-03-04 3:18 ` Ingo Molnar 2010-03-04 4:00 ` Randy Dunlap @ 2010-03-04 8:42 ` David Miller 1 sibling, 0 replies; 4+ messages in thread From: David Miller @ 2010-03-04 8:42 UTC (permalink / raw) To: mingo; +Cc: rdunlap, sfr, linux-next, linux-kernel, shemminger, bridge, netdev From: Ingo Molnar <mingo@elte.hu> Date: Thu, 4 Mar 2010 04:18:47 +0100 > I suspect Randy went by the MAINTAINERS entry - you might want to add netdev > as a second 'L:' line: > > ETHERNET BRIDGE > M: Stephen Hemminger <shemminger@linux-foundation.org> > L: bridge@lists.linux-foundation.org > W: http://www.linux-foundation.org/en/Net:Bridge > S: Maintained > F: include/linux/netfilter_bridge/ > F: net/bridge/ > > To make it really clear that netdev must be Cc:-ed for those patches. Thanks for pointing that out, I've made this addition. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-03-04 8:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20100302180915.1388d3f3.sfr@canb.auug.org.au>
[not found] ` <4B8D4607.8070603@xenotime.net>
2010-03-03 9:23 ` [PATCH -next] bridge: depends on INET David Miller
2010-03-04 3:18 ` Ingo Molnar
2010-03-04 4:00 ` Randy Dunlap
2010-03-04 8:42 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).